Add docs for Jupyter NB test suite #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which should make debugging somewhat less painful
etpinard
commented
Jan 6, 2017
| class PlotlyJupyterTestDeps(TestCase): | ||
|
|
||
| def test_node_modules(self): | ||
| self.assertTrue(path.isdir(PATH_NODE_MODULES)) |
There was a problem hiding this comment.
@theengineear this test will fail when someone forgets to npm install before running these tests. It should make debugging a little easier.
There was a problem hiding this comment.
Ah, nice! yah, that's a simple first-pass catch for sure.
|
^^ damn, that image server test still failed, rebuilding for now... I need to get to the bottom of that one. |
|
💃 👯 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up on #549
The pipeline for Jupyter NB tests is anything but trivial, so might as well 📚 it!
@theengineear @Kully @cldougl