Missing LegendGroupTitle on other trace types? #109
Comments
|
Simply missing and willing to accept pull requests :)
…________________________________
From: Kai Howelmeyer ***@***.***>
Sent: Wednesday, October 26, 2022 9:19:39 PM
To: igiagkiozis/plotly ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [igiagkiozis/plotly] Missing LegendGroupTitle on other trace types? (Issue #109)
The LegendGroupTitle seems only supported for Scatter3D at this point. For example, the BoxPlot only offers to set a legend group. But there is no way to set the LegendGroupTitle? Is that on purpose or is it simply missing and should be added?
—
Reply to this email directly, view it on GitHub<#109>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHSVKWGM45ETGKDVV7ZQHIDWFGG5XANCNFSM6AAAAAARPLRS5U>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
kaihowl
added a commit
to kaihowl/plotly
that referenced
this issue
Oct 29, 2022
kaihowl
added a commit
to kaihowl/plotly
that referenced
this issue
Oct 29, 2022
kaihowl
added a commit
to kaihowl/plotly
that referenced
this issue
Oct 29, 2022
|
@mfreeborn, happy to oblige. See #110. |
|
That's much appreciated. I would expect to have some time on Monday or Tuesday to have a proper look at merging the PR.
…________________________________
From: Kai Howelmeyer ***@***.***>
Sent: Saturday, October 29, 2022 12:21:39 PM
To: igiagkiozis/plotly ***@***.***>
Cc: Michael Freeborn ***@***.***>; Mention ***@***.***>
Subject: Re: [igiagkiozis/plotly] Missing LegendGroupTitle on other trace types? (Issue #109)
@mfreeborn<https://github.com/mfreeborn>, happy to oblige. See #110<#110>.
legendrank is another candidate to consistently add to all traces. I can follow up with that, if #110<#110> gets merged.
—
Reply to this email directly, view it on GitHub<#109 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHSVKWBZTCYRZ2K3MQJKYYTWFUCEHANCNFSM6AAAAAARPLRS5U>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
mfreeborn
added a commit
that referenced
this issue
Nov 2, 2022
* feat: add legendgrouptitle too all existing traces Fixes #109 * update changelog Co-authored-by: Michael Freeborn <michaelfreeborn1@gmail.com>
|
Closed by #110, many thanks :) |
mfreeborn
added a commit
that referenced
this issue
Nov 3, 2022
* Refactor examples and readme (#113) * update main readme * update plotly_kaleido readme * update readme * typo * add readme * Refactor examples and readme * update changelog * fix CI workflow * update workflows * tpyo * formatting * fix workflows * update workflows * update readme * update readme * update url * final tweaks * Remove 'static lifetime requirement for `Plot.to_inline_html()` (#115) * remove 'static lifetime requirement * update changelog * add `legend_group_title` to existing traces (#110) * feat: add legendgrouptitle too all existing traces Fixes #109 * update changelog Co-authored-by: Michael Freeborn <michaelfreeborn1@gmail.com> * Traces for Mesh3d, Image, ScatterMapbox (#88) * Add basic Mesh3D trace functionality * Add basic Image trace functionality * Add basic ScatterMapbox functionality * Fix compilation errors due to merge * Copy some setters * Fill in some more Mesh3D setters * Complete the Mesh3D setters * Complete the Image setters * Sketch idea of ImageData trait * Complete the ScatterMapbox setters * Add tests for Mesh3D * Fix cargo warnings * Make greater use of IntoIterator trait * Add tests for Image * Add tests for ScatterMapbox * Fix compilation errors * Insert _ in setter names * Run rustfmt and add line breaks to documentation * Add jupyter lab examples for Mesh3D, Image, ScatterMapbox * Update CHANGELOG * Remove setter assertions * refactoring * fix tests * formatting * add ImageData trait * add Image trace examples * add mesh3d example * rustfmt * add map example * tweak zoom data type * rustfmt * clippy * update workflows Co-authored-by: Michael Freeborn <michaelfreeborn1@gmail.com> * add plotly_image to features list * v0.8.2 Co-authored-by: Kai Howelmeyer <kai@hoewelmeyer.eu> Co-authored-by: Joel Sjögren <joelsjogren.wii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
LegendGroupTitleseems only supported forScatter3DandSankeyat this point. For example, theBoxPlotonly offers to set a legend group. But there is no way to set theLegendGroupTitle? Is that on purpose or is it simply missing and should be added?The text was updated successfully, but these errors were encountered: