-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LayoutScene
#153
Merged
Merged
Add LayoutScene
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed layout_scene.drag_mode type
Draft for CHANGELOG.md
Resolved everything :) When it comes to things like enforcing e.g. non-zero parameters to certain types like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I'd like to discuss a few things. There are a few remaining TODOs that need your attention. One specific concern involves handling arguments below zero to
AspectRatio
- I'd appreciate your advice on how to approach this.Additionally, do you think it would be a good idea to rename the struct
LayoutScene
to justScene
orScene3D
?I also updated the
customized_scatter3d_plot()
example in the3d_charts
section. The example now includes most of the newly implemented fields and produces a very 'customized' plot.I'm open to any feedback or suggestions you may have.