Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LayoutScene #153

Merged
merged 15 commits into from
Jul 27, 2023
Merged

Add LayoutScene #153

merged 15 commits into from
Jul 27, 2023

Conversation

tectin0
Copy link
Contributor

@tectin0 tectin0 commented Jul 19, 2023

Hi team,

I'd like to discuss a few things. There are a few remaining TODOs that need your attention. One specific concern involves handling arguments below zero to AspectRatio - I'd appreciate your advice on how to approach this.

Additionally, do you think it would be a good idea to rename the struct LayoutScene to just Scene or Scene3D?

I also updated the customized_scatter3d_plot() example in the 3d_charts section. The example now includes most of the newly implemented fields and produces a very 'customized' plot.

newplot (2)

I'm open to any feedback or suggestions you may have.

@mfreeborn
Copy link
Contributor

Resolved everything :) When it comes to things like enforcing e.g. non-zero parameters to certain types like AspectRatio, we currently do the simplest thing of allowing the full range of values and let plotlyjs handle the problem. It will typically either clamp the provided value to the nearest valid value, substitute the invalid value with the default or ignore the argument altogether.

@mfreeborn mfreeborn merged commit 3a9f7ef into plotly:master Jul 27, 2023
18 checks passed
@tectin0 tectin0 deleted the Add-LayoutScene branch July 27, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants