changed the expected type for HeatMap.z
from Option<Vec<Z>>
to Option<Vec<Vec<Z>>>
#157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
Vec<Vec<T>>
as an input forHeatMap.z
it infers thatZ
has the typeVec<T>
instead ofT
. This prevents.zmin()
and.zmax()
from working.Example:
Changing the type to
Option<Vec<Vec<Z>>
results in a correctly inferred type ofZ
and.zmin()
and.zmax()
work correctlyalso added
customized_heat_map
function to showcase the working zmin and zmax