Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hyperlinks to point to new repository url #193

Merged
merged 1 commit into from
May 14, 2024
Merged

fix hyperlinks to point to new repository url #193

merged 1 commit into from
May 14, 2024

Conversation

andrei-ng
Copy link
Collaborator

@andrei-ng andrei-ng commented Apr 26, 2024 •
edited
Loading

  • change references from master to main branch
  • change hyperlinks throught the repo to point to new repository url
  • similarly, fix the hyperlinks in the Rust book

@andrei-ng andrei-ng self-assigned this Apr 26, 2024
@ndrezn
Copy link
Member

ndrezn commented Apr 29, 2024

Is this replacing #190?

@andrei-ng
Copy link
Collaborator Author

Is this replacing #190?

No. It.is merely based on the same branch that #190 will merge. Once that is merged, I will rebase this. It involves a bit more work. All the examples and READMEs still use the old urls/refs.

@andrei-ng andrei-ng force-pushed the change-branch-reference branch 3 times, most recently from 400b113 to 2e66338 Compare April 30, 2024 21:46
@plotly plotly deleted a comment from ndrezn Apr 30, 2024
ndrezn
ndrezn reviewed Apr 30, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@andrei-ng andrei-ng force-pushed the change-branch-reference branch 2 times, most recently from 9ea7a3b to 03bf925 Compare May 14, 2024 19:32
@codecov Codecov
Copy link

codecov bot commented May 14, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@andrei-ng andrei-ng marked this pull request as ready for review May 14, 2024 20:07
@andrei-ng andrei-ng mentioned this pull request May 14, 2024
Closed
@andrei-ng andrei-ng changed the title change references to old default branch fix hyperlinks to point to new repository url May 14, 2024
@andrei-ng
Copy link
Collaborator Author

@ndrezn please review

@andrei-ng
fix references to point to new repo url and main branch
e4f746e 
- change url links to plotly/plotly.rs and from master to main
- fix refs in mdbook and in README
- fix shields.io links

Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
ndrezn
ndrezn approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ndrezn ndrezn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Awesome 🧼 PR. Will be great to get these new references published to cargo 🚀

@andrei-ng andrei-ng merged commit a00ab93 into main May 14, 2024
17 of 18 checks passed
@andrei-ng andrei-ng deleted the change-branch-reference branch May 14, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndrezn ndrezn ndrezn approved these changes

Assignees

@andrei-ng andrei-ng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrei-ng @ndrezn