Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Table trace #207

Merged
merged 15 commits into from
Jun 19, 2024
Merged

Add Table trace #207

merged 15 commits into from
Jun 19, 2024

Conversation

naijim
Copy link
Contributor

@naijim naijim commented Jun 17, 2024

this PR clears conflict of #165

@naijim naijim changed the title table trace: ressolve conflict table trace: resolve conflict Jun 17, 2024
@baiguoname baiguoname mentioned this pull request Jun 17, 2024
@andrei-ng
Copy link
Collaborator

andrei-ng commented Jun 18, 2024

@andrei-ng
Copy link
Collaborator

andrei-ng commented Jun 18, 2024

@naijim could you also fix the examples: https://github.com/plotly/plotly.rs/actions/runs/9561890518/job/26357299369?pr=207

@naijim I fixed the Clippy warnings in this PR, so if you update / rebase on main and fix the examples, this PR would be ready for merging.

@naijim
Copy link
Contributor Author

naijim commented Jun 19, 2024

@andrei-ng The example has been fixed.

@andrei-ng andrei-ng changed the title table trace: resolve conflict Add Table trace Jun 19, 2024
Signed-off-by: Andrei Gherghescu <8067229+andrei-ng@users.noreply.github.com>
@andrei-ng andrei-ng merged commit 8713ad2 into plotly:main Jun 19, 2024
17 of 19 checks passed
@andrei-ng andrei-ng mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants