Multi axes #77
Multi axes #77
Conversation
This requires plotly.Axes methods so we shamefully hack those on for now
When autorange=true range components are not visible
TraceSelector was not updated when we moved to the container system. Tests!
A variables main file defines the customizable variables in the editor. This is only partially complete. Better standardization and coverage is required. Use a default vars file to assign plotly defaults to the customizable variables.
The underlying modal is useful to other dropdown like components so that has been split into something called ModalBox
| <LayoutPanel group="Style" name={_('Axes')}> | ||
| <AxesFold name={_('Titles')}> | ||
| <AxesSelector /> | ||
| <Dropdown |
There was a problem hiding this comment.
This is what the API for axes will look like. A layout connected component wrapping an Axes connected component wrapping a generic container connected component.
If you took away the components and left only the higher order wrappers it would like this:
connectLayoutToPlot(connectAxesToLayout(connectToContainer(<Field />)));In fact in principal that should work. I better make sure it does and test it.
| value = defaultValue; | ||
| } else { | ||
| value = propValue; | ||
| } |
There was a problem hiding this comment.
the new multiAxes framework has resulted in vastly simpler widget code. They don't need to know about multiValued anything so far!
src/lib/connectAxesToLayout.js
Outdated
| * Test that we can connectLayoutToPlot(connectAxesToLayout(Panel)) | ||
| */ | ||
| function setMultiValuedContainer(intoObj, fromObj, key, searchArrays) { | ||
| var intoVal = intoObj[key], |
There was a problem hiding this comment.
@alexcjohnson this is your mergeAttr function from graph_edit.js :)
There was a problem hiding this comment.
This file contains the meat of handling multi-values. It's pretty similar to WS1
| if (fv === MULTI_VALUED) { | ||
| return MULTI_VALUED_PLACEHOLDER; | ||
| } | ||
| return fv; |
There was a problem hiding this comment.
unpackPlotProps, the last thing to run before the widget layer handles the transformation of a MULTI_VALUED value (which contains an escape character) to MULTI_VALUED_PLACEHOLDER which is ---.
Special purpose components can and do override this particular behaviour when necessary.
| export function noShame(opts) { | ||
| if (opts.plotly && !opts.plotly.Axes) { | ||
| opts.plotly.Axes = { | ||
| list, |
There was a problem hiding this comment.
@alexcjohnson halp
There was a problem hiding this comment.
Leave it for now - in fixing plotly/plotly.js#2125 I'm adding fullLayout._subplots which will also list x and y axes, which will moot this, mostly at least - might still need special handling for 3D and such but suffice to say it's in flux right now.
|
@alexcjohnson this is ready to look at. I have annotated the more interesting parts of the code. Thanks! |
| if (isNumeric(defaultValue)) { | ||
| valueUpdate = defaultValue; | ||
| } else { | ||
| // TODO smarter handling depending if user decrements or increments? |
There was a problem hiding this comment.
I suppose you could make some argument like increment should bump all values up to the biggest one and decrement should bump all values to the smallest... but that sounds like a major headache and I'm not sure if it's really worth much.
Canvas size
Symbol selector
Annotation of important pieces of this code will arrive in a day or so