Axes not redrawing after layout change

[igorpejic]

After migrating to plotly.js@1.34.0 and react-plotly@1.4.0 axes are not being redrawn after changing the number of axes in layout.

Before:

After:

https://codepen.io/igorpejic/pen/yvjxMY?editors=1010

I have tried adding the datarevision argument, but it didn't help.

(Let me know if this is a proper fit for react-plotly.js or I should post it to plotly.js)

[nicolaskruchten]

This is the right place, and thanks for the easy to see demo! I'll try to get a fix or answer for you this week.

[nicolaskruchten]

@alexcjohnson is this one of those cases where Plotly.react needs a bit of extra help to clean up axes?

[alexcjohnson]

Looks like a plotly.js bug, it's not specific to Plotly.react, I can get this to happen with Plotly.deleteTraces too:

Plotly.newPlot(gd,
    [{y: [1,2,3]}, {y: [10, 30, 20], yaxis: 'y2'}],
    {yaxis2: {side: 'right', overlaying: 'y'}}
);
Plotly.deleteTraces(gd, [1]);

I'll make a new issue for it over there.

[igorpejic]

I have temporarily solved the issue by manually checking if datarevision has changed in react-plotly.js in my own fork.
igorpejic@76756e4

After some investigation in plotly.js I assume the bug was introduced by: plotly/plotly.js#2341 and plotly/plotly.js#2227

Specifically commits like this which are connected with different restyle logic based on traces and not axis: plotly/plotly.js@aab4f11

[nicolaskruchten]

This is fixed with the latest version of plotly.js https://github.com/plotly/plotly.js/releases/tag/v1.35.0