Use plotly-dist as peer dep to fix import issues #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In principle this should work, but so should the current setup with the peer dependency on |
|
There must be some module resolve voodoo going wrong when using the non-bundled dist version. I don't know too much about the plotly.js internals, so I can only surmise things here. In any case it's most likely an issue with plotly.js instead of react-plotly.js. The really strange thing about it is that it seems to bundle fine with Webpack, whereas Browserify starts choking. |
This was referenced Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #93 although I'm slightly worried if this would require a (possibly unwanted) new major version.