Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotters: update chrono dependency to 0.4.32 #625

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

eric-seppanen
Copy link
Contributor

@eric-seppanen eric-seppanen commented Aug 3, 2024

The plotters code makes use of AddAssign on chrono::Duration (added in 24bf063), but that wasn't added to chrono until 0.4.32.

Without this fix, if an existing workspace adds plotters but already has a Cargo.lock containing an earlier release of chrono 0.4.x, plotters will fail to compile.

Fixes #624.

The plotters code makes use of `AddAssign` on `chrono::Duration`, but
that wasn't added to chrono until 0.4.32.
Copy link
Member

@AaronErhardt AaronErhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AaronErhardt AaronErhardt merged commit 7e7d2aa into plotters-rs:master Aug 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] plotters fails to compile in a workspace using chrono 0.4.31
2 participants