fix(pie): make dimensions required props

plouc · Nov 9, 2020 · fe0e43c · fe0e43c
1 parent d63ad74
commit fe0e43c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/packages/pie/src/Pie.tsx b/packages/pie/src/Pie.tsx
@@ -31,8 +31,8 @@ const Pie = <RawDatum, >({
     innerRadius: innerRadiusRatio = defaultProps.innerRadius,
     cornerRadius = defaultProps.cornerRadius,
 
-    width = 0,
-    height = 0,
+    width,
+    height,
     margin: partialMargin,
 
     colors = defaultProps.colors,

diff --git a/packages/pie/src/PieCanvas.tsx b/packages/pie/src/PieCanvas.tsx
@@ -90,8 +90,8 @@ const PieCanvas = <RawDatum, >({
     innerRadius: innerRadiusRatio = defaultProps.innerRadius,
     cornerRadius = defaultProps.cornerRadius,
 
-    width = 0,
-    height = 0,
+    width,
+    height,
     margin: partialMargin,
     pixelRatio = 1,
 

diff --git a/packages/pie/src/types.ts b/packages/pie/src/types.ts
@@ -74,7 +74,7 @@ export type PieCustomLayer<RawDatum> = React.FC<PieCustomLayerProps<RawDatum>>
 
 export type PieLayer<RawDatum> = PieLayerId | PieCustomLayer<RawDatum>
 
-export type CommonPieProps<RawDatum> = Dimensions & {
+export type CommonPieProps<RawDatum> = {
     id: string | DatumIdAccessorFunction<RawDatum>
     value: string | DatumValueAccessorFunction<RawDatum>
     valueFormat?: string | ValueFormatter
@@ -130,26 +130,30 @@ export type PieHandlers<RawDatum, ElementType> = {
 }
 
 export type PieSvgProps<RawDatum> = DataProps<RawDatum> &
+    Dimensions &
     Partial<CommonPieProps<RawDatum>> &
     SvgDefsAndFill<ComputedDatum<RawDatum>> &
     PieHandlers<RawDatum, SVGPathElement> & {
         layers?: PieLayer<RawDatum>[]
     }
 
 export type CompletePieSvgProps<RawDatum> = DataProps<RawDatum> &
+    Dimensions &
     CommonPieProps<RawDatum> &
     SvgDefsAndFill<ComputedDatum<RawDatum>> &
     PieHandlers<RawDatum, SVGPathElement> & {
         layers: PieLayer<RawDatum>[]
     }
 
 export type PieCanvasProps<RawDatum> = DataProps<RawDatum> &
+    Dimensions &
     Partial<CommonPieProps<RawDatum>> &
     Pick<PieHandlers<RawDatum, HTMLCanvasElement>, 'onClick' | 'onMouseMove'> & {
         pixelRatio?: number
     }
 
 export type CompletePieCanvasProps<RawDatum> = DataProps<RawDatum> &
+    Dimensions &
     CommonPieProps<RawDatum> &
     Pick<PieHandlers<RawDatum, HTMLCanvasElement>, 'onClick' | 'onMouseMove'> & {
         pixelRatio: number