Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing peer dependency warnings in yarn 3 #1788

Closed
MarcCelani-at opened this issue Sep 30, 2021 · 7 comments
Closed

Missing peer dependency warnings in yarn 3 #1788

MarcCelani-at opened this issue Sep 30, 2021 · 7 comments
Labels

Comments

@MarcCelani-at
Copy link

Describe/explain the bug
Yarn 3 has peer dependency warnings

To Reproduce

  1. yarn set version berry
  2. yarn install

Expected behavior
No missing peer dependency warnings from nivo

Observed behavior
A spew of warnings...
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (pb278c), requested by @nivo/legends
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (pe2d25), requested by @nivo/bar
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (pa076b), requested by @nivo/chord
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (p267df), requested by @nivo/circle-packing
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (pb1bcb), requested by @nivo/core
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (p177a7), requested by @nivo/heatmap
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (p8137f), requested by @nivo/line
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (p33159), requested by @nivo/parallel-coordinates
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (pc1e6c), requested by @nivo/pie
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (p4966a), requested by @nivo/treemap
➤ YN0002: │ @nivo/api@workspace:api doesn't provide prop-types (p55ba8), requested by @nivo/waffle
➤ YN0060: │ @nivo/api@workspace:api provides react (pc680c) with version 17.0.2, which doesn't satisfy what @nivo/bar and some of its descendants request
...

@stale
Copy link

stale bot commented Dec 29, 2021

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Dec 29, 2021
@MarcCelani-at
Copy link
Author

MarcCelani-at commented Dec 29, 2021 via email

@stale stale bot removed the stale label Dec 29, 2021
@plouc
Copy link
Owner

plouc commented Jan 3, 2022

Fixed for (not required as those packages now rely on TypeScript):

  • @nivo/bar
  • @nivo/chord
  • @nivo/circle-packing
  • @nivo/pie
  • @nivo/treemap

@charrondev
Copy link

charrondev commented Feb 6, 2022

I'm noticing a few other packages that are missing peer dependencies.

➤ YN0002: │ @nivo/annotations@npm:0.79.1 [c9087] doesn't provide prop-types (p80e8c), requested by @nivo/colors
➤ YN0002: │ @nivo/annotations@npm:0.79.1 [c9087] doesn't provide react-dom (pa5c10), requested by @react-spring/web
➤ YN0002: │ @nivo/arcs@npm:0.79.1 [5decd] doesn't provide prop-types (p7cdc2), requested by @nivo/colors
➤ YN0002: │ @nivo/arcs@npm:0.79.1 [5decd] doesn't provide react-dom (p17969), requested by @react-spring/web
➤ YN0002: │ @nivo/axes@npm:0.79.0 [c9087] doesn't provide react-dom (p52b72), requested by @react-spring/web
➤ YN0002: │ @nivo/bar@npm:0.79.1 [e6026] doesn't provide prop-types (p36813), requested by @nivo/colors
➤ YN0002: │ @nivo/bar@npm:0.79.1 [e6026] doesn't provide prop-types (p64a1e), requested by @nivo/axes
➤ YN0002: │ @nivo/bar@npm:0.79.1 [e6026] doesn't provide prop-types (pcda45), requested by @nivo/legends
➤ YN0002: │ @nivo/bar@npm:0.79.1 [e6026] doesn't provide react-dom (pd680f), requested by @react-spring/web
➤ YN0002: │ @nivo/core@npm:0.79.0 [e6026] doesn't provide react-dom (p27453), requested by @react-spring/web
➤ YN0002: │ @nivo/line@npm:0.79.1 [e6026] doesn't provide react-dom (p58be6), requested by @react-spring/web
➤ YN0002: │ @nivo/pie@npm:0.79.1 [e6026] doesn't provide prop-types (pb26a7), requested by @nivo/colors
➤ YN0002: │ @nivo/pie@npm:0.79.1 [e6026] doesn't provide prop-types (p94c8b), requested by @nivo/legends
➤ YN0002: │ @nivo/tooltip@npm:0.79.0 [c9087] doesn't provide react-dom (p9fe80), requested by @react-spring/web

It looks like react-spring has a peer-dependency on react-dom. Following #1505 it seems this project only cares about web so a PR to make add react-dom and prop-types as peer dependencies where necessary should resolve this.

@Sourabh-24
Copy link

npm ERR! peer dep missing: @nivo/core@0.79.0, required by @nivo/line@0.79.1 and many more peer dependency asked to solve manually after meteor npm audit

@stale
Copy link

stale bot commented May 30, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label May 30, 2022
@stale
Copy link

stale bot commented Jun 11, 2022

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants