Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing peer dependencies from multi target react-spring #1505

Closed
nikolaik opened this issue May 6, 2021 · 3 comments · Fixed by #1517
Closed

Missing peer dependencies from multi target react-spring #1505

nikolaik opened this issue May 6, 2021 · 3 comments · Fixed by #1517

Comments

@nikolaik
Copy link
Contributor

nikolaik commented May 6, 2021 •
edited
Loading

Describe/explain the bug
After upgrading the react-spring dependency in #1480 we now get warnings on missing peer dependencies. Does nivo support any other target than web? If not, could we simple switch to @react-spring/web ?

npm WARN @react-spring/konva@9.1.2 requires a peer of konva@>=2.6 but none is installed. You must install peer dependencies yourself.
npm WARN @react-spring/konva@9.1.2 requires a peer of react-konva@>=16.8 but none is installed. You must install peer dependencies yourself.
npm WARN @react-spring/native@9.1.2 requires a peer of react-native@>=0.58 but none is installed. You must install peer dependencies yourself.
npm WARN @react-spring/three@9.1.2 requires a peer of @react-three/fiber@>=6.0 but none is installed. You must install peer dependencies yourself.
npm WARN @react-spring/three@9.1.2 requires a peer of three@>=0.126 but none is installed. You must install peer dependencies yourself.
npm WARN @react-spring/zdog@9.1.2 requires a peer of react-zdog@>=1.0 but none is installed. You must install peer dependencies yourself.
npm WARN @react-spring/zdog@9.1.2 requires a peer of zdog@>=1.0 but none is installed. You must install peer dependencies yourself.

To Reproduce

  1. npm i @nivo/core@0.69.1
  2. Check terminal output

Expected behavior

No warnings about peer dependencies
@wyze
Copy link
Contributor

wyze commented May 6, 2021

Does nivo support any other target than web?

No we don't.

If not, could we simple switch to @react-spring/web ?

Possibly? If it gets rid of the peer dependencies warnings from react-spring and keeps the same functionality, it is worth a shot.

nikolaik added a commit to nikolaik/nivo that referenced this issue May 13, 2021
@nikolaik
chore(deps): Use @react-spring/web
055e5b1 
Replace use of multi target react-spring to avoid peer dependency
warnings. Update package.json files, JS imports and lock deps

Close plouc#1505
@nikolaik nikolaik mentioned this issue May 13, 2021
Merged
@nikolaik
Copy link
Contributor Author

If not, could we simple switch to @react-spring/web ?

Possibly? If it gets rid of the peer dependencies warnings from react-spring and keeps the same functionality, it is worth a shot.

Gave it a shot 🤞

@carlosprietobarron
Copy link

Hello, do you think this problem will be solved any time soon?

wyze pushed a commit that referenced this issue May 22, 2021
@nikolaik
chore(deps): Use @react-spring/web (#1517)
3cf486f 
Replace use of multi target react-spring to avoid peer dependency
warnings. Update package.json files, JS imports and lock deps

Close #1505
@charrondev charrondev mentioned this issue Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): Use @react-spring/web nikolaik/nivo
3 participants
@nikolaik @wyze @carlosprietobarron