-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): upgrade react-spring to v9.1.2 #1480
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 784e673:
|
Thank you so much @jamesdh! Hopefully, it will be merged soon (not sure the project is still actively maintained though). |
@plouc Any chance for you to take a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jamesdh, would you mind upgrading to the latest version of the package? Looks like it is now 9.1.1
. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the suggestion to update it to the latest version, LGTM, thank you for this!
9fbd4ee
to
8ce1b28
Compare
@jamesdh I saw you upgraded to the latest and that broke the build. I was working on fixing the errors and didn't know if you were as well. I'll continue working on it and push my changes here. |
@wyze @plouc @rogemus I originally used 9.0.1 because I knew it should just be a drop-in replacement that works for now. 9.1.x was out when I first submitted this PR, but I saw in its release notes that it contained breaking changes and I didn't want to bother with them for the time being. I just tried upgrading to 9.1.2 and sure enough, it causes numerous breakages during the build. I say we just merge this for now since using 9.0.0.rc3 is problematic beyond just this script issue:
Then we can then do another PR that contains the extra work to get 9.1.x working. EDIT: Nevermind...@wyze took care of the build issues! |
Thats fine. I reapplied your patch of the upgrade and then did another commit that fixes the type errors. This allowed the build to pass locally, so we will see what CI says. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks.
Upgrades from react-spring @ 9.0.0-rc3 to 9.0.1
I have to imagine a lot of people stumbled upon this bug and rather than looking for a solution as described in #1290, they simply downgraded. After accidentally running into it again today I decided it's time to see if a fix is available, so here you go!
Fixes #1290
Fixes #1453