Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firstWeekday attr to calendar/TimeRange #2299

Merged
merged 6 commits into from
Apr 28, 2023

Conversation

yzalvov
Copy link
Contributor

@yzalvov yzalvov commented Apr 24, 2023

So that Monday could be first.

Screenshot 2023-04-24 at 18 59 25

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b46a2ce:

Sandbox Source
nivo Configuration

packages/calendar/src/types.ts Outdated Show resolved Hide resolved
packages/calendar/src/compute/timeRange.ts Outdated Show resolved Hide resolved
packages/calendar/src/compute/timeRange.ts Outdated Show resolved Hide resolved
packages/calendar/src/compute/timeRange.ts Outdated Show resolved Hide resolved
packages/calendar/src/props.ts Outdated Show resolved Hide resolved
@plouc plouc added the 📆 calendar @nivo/calendar package label Apr 25, 2023
@yzalvov yzalvov changed the title Add firstDayOfWeek attr to calendar/TimeRange Add firstWeekday attr to calendar/TimeRange Apr 25, 2023
packages/calendar/src/types.ts Outdated Show resolved Hide resolved
@yzalvov yzalvov requested a review from plouc April 26, 2023 10:33
@yzalvov
Copy link
Contributor Author

yzalvov commented Apr 28, 2023

Hi @plouc, is there anything else you'd want me to add?

Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plouc
Copy link
Owner

plouc commented Apr 28, 2023

Hi @yzalvov, nope, LGTM, will merge as soon as tests pass, thank you!

@plouc plouc merged commit 1dbd7f2 into plouc:master Apr 28, 2023
@yzalvov
Copy link
Contributor Author

yzalvov commented May 1, 2023

Hi @plouc, thanks for your prompt reaction and thank you for the library!

FYI:

  1. The tooltip seems to be broken after your recent updates. Neither default nor custom tooltip components are rendered for me on current master.
  2. No updates of the interactive docs regarding this new firstWeekday feature found available https://nivo.rocks/time-range

@plouc
Copy link
Owner

plouc commented May 1, 2023

I moved to vercel, but didn't update the DNS yet, you can see it here for now: https://nivo-nxi8sxerj-plouc.vercel.app/time-range/. Regarding the tooltip issue, I think it's an old issue due to a cyclic dependency (@nivo/core -> @nivo/tooltip -> @nivo/core), I need to fix this among other things.

@yzalvov
Copy link
Contributor Author

yzalvov commented May 1, 2023

Thanks to @jfache for the #613, I borrowed some bits. Also might be helpful for someone from #1764

@plouc
Copy link
Owner

plouc commented May 1, 2023

DNS updated, it might take some time to propagate.

@yzalvov
Copy link
Contributor Author

yzalvov commented May 5, 2023

Hi @plouc, thanks so much for the library by the way 🤓 Helps a lot.. Just checking, is the broken tooltip situation resolved? If not, could you share a link to the issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📆 calendar @nivo/calendar package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants