Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix area rendering disparity of line canvas compared to line svg #2558

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

MatinAniss
Copy link
Contributor

This PR fixes the inconsistent rendering of enableArea when comparing SVG to Canvas, seen below is a example of the issue. The SVG line renders the area correctly when using a stacked line graph but the current implementation of the Canvas line renders it improperly.

This fix will make the canvas version conform with how the svg version is displayed.

SVG Line Area example (Current Good ✔️):
svg-rendered-normal

Canvas Line Area example (Current Not Good ❌):
canvas-rendered-broken

Canvas Line Area example (Fixed Good ✔️):
cavas-rendered-fixed

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 7:57am

Copy link

codesandbox-ci bot commented Apr 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d17172c:

Sandbox Source
nivo Configuration

@MatinAniss
Copy link
Contributor Author

Here is another example from the nivo.rocks website which shows this improvement, it looks much better!

Fixed New:
image

Old:
image

@plouc plouc merged commit 3f090bc into plouc:master Apr 29, 2024
5 checks passed
@MatinAniss MatinAniss deleted the fix-area branch April 30, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants