marimekko: all dimension input data is propagated

[Linschlager]

Currently, only the dimensionId as well as the patched value function are propagated to the computed data.
In order to use custom colors per dimension, it is necessary to propagate the entire object to the computed one so the dimension data is still available.

Resolves #2677

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nivo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2025 0:33am

[plouc]

Hi @Linschlager,

First of all, thank you for this contribution!

I'm not convinced that merging the raw dimension directly into the DimensionDatum is the best approach.
I think this could be confusing, as we could end up with some arbitrary properties in DimensionDatum, especial ly for users who don't use TypeScript.
It would probably be best to isolate, for example adding DimensionDatum.original or something similar, and maybe to use a generic for the dimensions if needed.
This approach would require using the colors property to get the color from DimensionDatum.original, but I think it would be cleaner.

Please let me know what you think.

[Linschlager]

Hi @Linschlager,

First of all, thank you for this contribution!

I'm not convinced that merging the raw dimension directly into the DimensionDatum is the best approach. I think this could be confusing, as we could end up with some arbitrary properties in DimensionDatum, especial ly for users who don't use TypeScript. It would probably be best to isolate, for example adding DimensionDatum.original or something similar, and maybe to use a generic for the dimensions if needed. This approach would require using the colors property to get the color from DimensionDatum.original, but I think it would be cleaner.

Please let me know what you think.

Thanks for the feedback, @plouc,

This approach just seemed like the quickest and easiest way to achieve my goal. I do agree, however, that it might cause unintended side effects by allowing arbitrary inputs this way.

I updated my PR to not merge the raw dimension in but in a separate field where the impact is much more contained.

I also updated the example to account for that. I think it's still reasonably nice to use.

[plouc]

LGTM