Allow access to the wrapped instance through component.wrappedInstance
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important if you want to access instance methods on a component which is wrapped by `ReactTimeout`. As an example, imagine you have an input component that needs to use `ReactTimeout`, but you also want to be able to focus the input. The interface is similar to `react-redux` - see: https://github.com/reactjs/react-redux/blob/fd436b1e024c4194d3f44dfcef8e30fd24a99a1a/src/components/connectAdvanced.js#:181 Test plan: Added a unit test.
|
Seems good, I'll look at it in a bit! |
plougsgaard
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important if you want to access instance methods on a component
which is wrapped by
ReactTimeout. As an example, imagine you have aninput component that needs to use
ReactTimeout, but you also want tobe able to focus the input.
The interface is similar to
react-redux- see:https://github.com/reactjs/react-redux/blob/fd436b1e024c4194d3f44dfcef8e30fd24a99a1a/src/components/connectAdvanced.js#:181
Test plan: Added a unit test.