logging reform: Transport,SFTP* _log() refactor #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploxiln
force-pushed
the
logging_reform
branch
3 times, most recently
from
dda756d to
708dcfe
Compare
Transport._log() does not take msg list, it takes format string SFTPClient/SFTPServer _log() method does not take msg list SFTPBase gets new _loglist() method for the rare list case Transport and SFTP* use proper logging format strings and separate arguments SFTPClient no longer needs %% escaping of log messages, now that it logs correctly SSHClient and AuthHandler always log with single msg string, so pass to Transport._log() as "%s", msg get rid of util.tb_strings(), instead _log() with exc_info=True so that lines of traceback are not separate log messages (inspired by paramiko#406) binascii.hexlify() returns bytes, decode to string for logging (inspired by paramiko#1661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport._log() does not take msg list, it takes format string
SFTPClient/SFTPServer _log() method does not take msg list
SFTPBase gets new _loglist() method for the rare list case
Transport and SFTP* use proper logging format strings
and separate arguments
SSHClient and AuthHandler always log with single msg string,
so pass to Transport._log() as "%s", msg
get rid of util.tb_strings(), instead _log() with exc_info=True
so that lines of traceback are not separate log messages
(inspired by paramiko#406)