Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sequel ORM #63

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Support Sequel ORM #63

merged 3 commits into from
Dec 6, 2018

Conversation

cmrd-senya
Copy link

No description provided.

@zealot128
Copy link
Member

hello. Thanks for your PR. Would you mind adding a test that demonstrates the usage?
Also an entry to README would be nice, that explains usage.

@cmrd-senya
Copy link
Author

Would you mind adding a test that demonstrates the usage?

I wouldn't mind, but I think you should accept #64 first, in order to avoid conflicts here.

@cmrd-senya
Copy link
Author

simple-captcha2 uses Rails generators to create a dummy application to test the gem against.

I added support for generating a Sequel based Rails application. It is activated by setting SEQUEL env. I added respective scenario to the travis configuration.

ORM is meant to be selected automatically, so in terms of usage it doesn't require any explicit user actions, except of including proper gems to user's Gemfile. I added a little note about this to the readme. (Note: this is not my idea, there was a support for ActiveRecord/Mongoid selection before my work).

@cmrd-senya
Copy link
Author

cmrd-senya commented Dec 5, 2018

Just in case I'll say that this is ready for a review

@zealot128 zealot128 merged commit 4000483 into pludoni:master Dec 6, 2018
@cmrd-senya cmrd-senya deleted the support-sequel branch December 6, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants