Skip to content
This repository has been archived by the owner on Jul 4, 2022. It is now read-only.

Uncouple emptying gas_meter from updating the gas spent for the block #68

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Uncouple emptying gas_meter from updating the gas spent for the block #68

merged 4 commits into from
Feb 26, 2020

Conversation

aliXsed
Copy link

@aliXsed aliXsed commented Feb 24, 2020

Closes #67

Uncouple emptying gas_meter from updating the gas spent for the block…
9e5d604 
…. However keep the update function for GasHandler as it seems to be relevant to this trait.
aliXsed
aliXsed commented Feb 24, 2020
View reviewed changes
frame/contracts/src/gas.rs Outdated Show resolved Hide resolved
@aliXsed aliXsed mentioned this pull request Feb 24, 2020
Merged
@cowboy-bebug
Copy link
Contributor

cowboy-bebug commented Feb 24, 2020 •
edited
Loading

I think the build errors are coming from the way we use the latest nightly in our circleci config. Let me fix it in another PR Actually the latest nightly probably fixes this.

@jordy25519
Copy link
Contributor

related: rustwasm/wasm-bindgen#2009

hoani
hoani reviewed Feb 25, 2020
View reviewed changes
frame/contracts/src/gas.rs Outdated Show resolved Hide resolved
hoani
hoani suggested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@hoani hoani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see requested changes, happy to discuss design decisions =)

frame/contracts/src/gas.rs Outdated Show resolved Hide resolved
In lining the call for mutating the gas-spent for blocks. This is bec…
8853cc6 
…ause the team see a new interface such as finish fo GasHandler as exposing.

The test for checking if gas-spent for the block increases correctly is removed as it couldn't be relevant with this new design.
jordy25519
jordy25519 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@jordy25519 jordy25519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY LGTM

@jordy25519 jordy25519 requested a review from hoani February 25, 2020 23:55
hoani
hoani approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@hoani hoani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cowboy-bebug
cowboy-bebug approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@cowboy-bebug cowboy-bebug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@aliXsed aliXsed merged commit d2319b9 into develop Feb 26, 2020
roy-powerfinance added a commit that referenced this pull request Feb 27, 2020
@roy-powerfinance
Merge remote-tracking branch 'origin/develop' into chore/bt_127_merge…
8742ccb 
…_substrate

* origin/develop:
  Uncouple emptying gas_meter from updating the gas spent for the block (#68)
jordy25519 pushed a commit that referenced this pull request Feb 27, 2020
@jordy25519
Uncouple emptying gas_meter from updating the gas spent for the block (…
9279d0b 
…#68)

* Uncouple emptying gas_meter from updating the gas spent for the block.
@aliXsed aliXsed deleted the refactor/67-uncoupled-gas-block-handling branch March 4, 2020 03:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cowboy-bebug cowboy-bebug cowboy-bebug approved these changes

@jordy25519 jordy25519 jordy25519 approved these changes

@hoani hoani hoani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncouple handling block gas spent from emptying gas meter
4 participants
@aliXsed @cowboy-bebug @jordy25519 @hoani