Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database error for MySQL InnoDB database without innodb_large_prefix extension #105

Closed
Zodiac1978 opened this issue Sep 30, 2018 · 3 comments

Comments

@Zodiac1978
Copy link
Member

First reported here:
https://wordpress.org/support/topic/fehler-bei-der-aktivierung-des-plugins-tabelle-wp_statify-wird-nicht-angelegt/

Could we check for this extension, catch this error and act accordingly?
Contao seems to be doing this:
contao/installation-bundle@1bdf0ec

@stklcode
Copy link
Contributor

Sure we can check for availability of the extension, we just jave to agree on a proper resoltion.

  1. Properly fail installation with a readable warning
  2. Simply skip the index creation and live with the performance impact
  3. Find a different solution like hashing the content and building an index table on that fixed-length hash?

Performance shouldn't be that much of an issue and only affects admin dashboard on sites with a high number of users, so I think version 2 is the way to go.

@stklcode stklcode added this to the 1.7.0 milestone Oct 2, 2018
@Zodiac1978 Zodiac1978 added the bug label Oct 3, 2018
@stklcode
Copy link
Contributor

stklcode commented Oct 3, 2018

I adapted the Contao checks, but I think their implementation is incomplete.

I tested on serveral servers and at least on one (Docker mariadb:10.1.36-bionic) the check returns false, but Index creation is possible.

Variable_name             | Value           || Condition
--------------------------|-----------------||-----------------------
innodb_large_prefix       | OFF             || not ON => continue
version                   | 10.1.36-MariaDB || < 10.2 => continue
innodb_file_format        | Antelope        || not Barracuda => fail
innodb_default_row_format | compact         || 
innodb_file_per_table     | ON              || 

To everything I read is should not be possible... Didn't check if this is a somehow patched 10.1 release.

@bueltge
Copy link
Member

bueltge commented Apr 19, 2020

The issue is ancient and not validated in several installations. So I mean we should close the issue for now and if we get it again, then restart the analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants