Skip to content

Only test ping on reservation creation if it's enabled on config #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only test ping on reservation creation if it's enabled on config #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions inc/reserveip.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,18 +184,21 @@ function showReservationForm($ip, $id_addressing, $rand) {
<td>" . _n("IP address", "IP addresses", 1) . "</td>
<td>" . $ip . "</td>
<td>";
$config = new PluginAddressingConfig();
$config->getFromDB('1');
$system = $config->fields["used_system"];

$ping_equip = new PluginAddressingPing_Equipment();
list($message, $error) = $ping_equip->ping($system, $ip);
if ($error) {
echo "<i class='fas fa-check-circle fa-1x' style='color:forestgreen'></i><span style='color:forestgreen'>&nbsp;";
echo __('Ping: no response - free IP', 'addressing');
} else {
echo "<i class='fas fa-exclamation-triangle fa-1x' style='color:orange'></i><span style='color:orange'>&nbsp;";
echo __('Ping: got a response - used IP', 'addressing');
$ping = $addressing->fields["use_ping"];
if ($ping == 1) {
$config = new PluginAddressingConfig();
$config->getFromDB('1');
$system = $config->fields["used_system"];

$ping_equip = new PluginAddressingPing_Equipment();
list($message, $error) = $ping_equip->ping($system, $ip);
if ($error) {
echo "<i class='fas fa-check-circle fa-1x' style='color:forestgreen'></i><span style='color:forestgreen'>&nbsp;";
echo __('Ping: no response - free IP', 'addressing');
} else {
echo "<i class='fas fa-exclamation-triangle fa-1x' style='color:orange'></i><span style='color:orange'>&nbsp;";
echo __('Ping: got a response - used IP', 'addressing');
}
}
echo "</span>";
echo "</td></tr>";
Expand Down