Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some missing asset injection classes #361

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Mirkk
Copy link

@Mirkk Mirkk commented Oct 12, 2023

Hi all,

I added some missing asset injection classes. They are now successfully in use on production servers since more than one year, and I would like to share them with you:

[softwareversioninjection.class.php] and [item_softwareversioninjection.class.php]: adding software, a "version" is required. With these additions it works to import software for a computer.

new files registered in setup.php:
[computervirtualmachineinjection.class.php]: for adding VMs to computers
[item_diskinjection.class.php] for adding disks

Feel free to modify and format each part of this code - I am not a php programmer and did these without an IDE and in part by trial and error to find ways to complete the imports.

There are still many parts missing in datainjection - i hope that this could be a way to slowly complete them.
PS: sorry, please ignore the first commit in this pull request - it is just from a merge of the latest release to the actual head.

@cedric-anne cedric-anne changed the base branch from develop to master November 16, 2023 09:49
@Mirkk
Copy link
Author

Mirkk commented Nov 17, 2023

Sorry, there are some issues on VM import - please wait with using this code.
Moreover, I don't understand why a subsequent commit on my repo ("Added schedulable imports with an AutomaticAction") was included in the push request here.

@cedric-anne cedric-anne requested review from stonebuzz, Rom1-B and AdrienClairembault and removed request for stonebuzz and cedric-anne February 21, 2024 08:05
@stonebuzz
Copy link
Contributor

I don't understand why a subsequent commit on my repo

seems introduceb by this commit bf7696e

a revert of this commit should be enough

Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants