Phpcs + PHPstan #184
Merged
Phpcs + PHPstan #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure |
|
Indeed, it was too simple :( |
stonebuzz
approved these changes
Apr 25, 2024
AdrienClairembault
requested changes
Apr 26, 2024
inc/ticket.class.php
Outdated
| } | ||
| //groups | ||
| $query_groups = "INSERT INTO glpi_groups_tickets | ||
| if (!$res = $DB->doQuery($query_users)) { |
There was a problem hiding this comment.
It look like $tickets is sent from the client, which mean this could become an SQL injection on GLPI 11 when autoescaping is removed.
We should either keep the deprecated query call or not use a raw string query here.
inc/ticket.class.php
Outdated
| Session::addMessageAfterRedirect(__('Error : adding actors (group)', "escalade"),false, ERROR); | ||
| exit; | ||
| } | ||
| if (!$res = $DB->doQuery($query_groups)) { |
inc/ticket.class.php
Outdated
| } | ||
|
|
||
| static function filter_actors(array $params = []): array { | ||
| if (! $res = $DB->doQuery($query_docs)) { |
AdrienClairembault
approved these changes
Apr 26, 2024
stonebuzz
approved these changes
Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add phpcs + phpstan