Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history task message #226

Merged
merged 21 commits into from
Aug 28, 2024
Merged

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Aug 2, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets !33795

Removed the code passage that added a group if the delete right was deactivated, as this was causing problems when cracking the escaldae spot (the delete right check is done in JavaScript).

@Lainow Lainow marked this pull request as ready for review August 2, 2024 10:19
@Lainow Lainow requested review from Rom1-B and RomainLvr August 2, 2024 10:19
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests, because it seems to me that this is the 3rd recent PR that modifies this part of the code.

@Lainow Lainow requested a review from Rom1-B August 5, 2024 09:46
tests/autoload.php Outdated Show resolved Hide resolved
tests/units/TaskMessage.php Outdated Show resolved Hide resolved
Co-authored-by: Romain Lecouvreur <102067890+RomainLvr@users.noreply.github.com>
tests/units/TaskMessageTest.php Outdated Show resolved Hide resolved
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 we have tests!

Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

Two minor things to fix and OK for merge

tests/bootstrap.php Outdated Show resolved Hide resolved
tests/bootstrap.php Show resolved Hide resolved
Lainow and others added 2 commits August 6, 2024 15:18
Co-authored-by: Adrien Clairembault <42734840+AdrienClairembault@users.noreply.github.com>
@AdrienClairembault
Copy link
Contributor

Log path still seems invalid:

image

tests/bootstrap.php Outdated Show resolved Hide resolved
@stonebuzz
Copy link
Contributor

@Lainow

can you adapt CHANGELOG.md ?

CHANGELOG.md Outdated Show resolved Hide resolved
@Lainow Lainow requested a review from stonebuzz August 28, 2024 10:50
@stonebuzz stonebuzz merged commit 9fa1761 into pluginsGLPI:main Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants