-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix history task message #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests, because it seems to me that this is the 3rd recent PR that modifies this part of the code.
0cdd690
to
f31f934
Compare
Co-authored-by: Romain Lecouvreur <102067890+RomainLvr@users.noreply.github.com>
2a432f9
to
9f3c04c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 we have tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
Two minor things to fix and OK for merge
Co-authored-by: Adrien Clairembault <42734840+AdrienClairembault@users.noreply.github.com>
can you adapt CHANGELOG.md ? |
Removed the code passage that added a group if the delete right was deactivated, as this was causing problems when cracking the escaldae spot (the delete right check is done in JavaScript).