Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task added from ajax climb #230

Merged

Conversation

stonebuzz
Copy link
Contributor

When using history to clib to specific group
image

related task is not added

image

nb : since https://github.com/pluginsGLPI/escalade/pull/200/files (bad copy paste)

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Copy link

@BorisNovg BorisNovg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stonebuzz, thank you!

Testing on a test virtual machine - I make a copy of the main server in a separate isolated network segment. GLPI 10.0.15.


Installing escalade version prior to your suggested patch - stonebuzz/escalade at 2d6e8ce 20240802 Download ZIP
The problem described in Issue 202 is reproduced, the test result - the yellow bar "Escalation to the group..." was not created.

Installing the escalade version with your suggested patch - stonebuzz/escalade at bd38490 20240827 Download ZIP
The problem described in Issue 202 is not reproduced, the test result - the yellow bar "Escalation to the group..." was created (as expected, Ok!).


Advanced Check - Installing last MASTER escalade version - pluginsGLPI/escalade at 9fa1761 20240828 Download ZIP
The problem described in Issue 202 is reproduced, the test result - the yellow bar "Escalation to the group..." was not created.


Addition in connection with comment:

            '_plugin_escalade_no_history' => true, // Prevent a duplicated task to be added

duplicated tasks with the proposed solution do not appear.

@stonebuzz stonebuzz merged commit ee4d333 into pluginsGLPI:main Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants