refactor(question): get field icon from dedicated method

Signed-off-by: btry <tbugier@teclib.com>
pluginsGLPI · Dec 4, 2019 · 1f63bcb · 1f63bcb
1 parent ef68bb6
commit 1f63bcb
Show file tree

Hide file tree

Showing 24 changed files with 140 additions and 1 deletion.
diff --git a/inc/fieldinterface.class.php b/inc/fieldinterface.class.php
@@ -196,4 +196,9 @@ public function LessThan($value);
     * @return boolean true if the field can work with anonymous forms
     */
    public function isAnonymousFormCompatible();
+
+   /**
+    * Gets HTML code for the icon of a field
+    */
+   public function getHtmlIcon();
 }
diff --git a/inc/fields/actorfield.class.php b/inc/fields/actorfield.class.php
@@ -323,4 +323,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return false;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-actor-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/checkboxesfield.class.php b/inc/fields/checkboxesfield.class.php
@@ -307,4 +307,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-checkboxes-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/datefield.class.php b/inc/fields/datefield.class.php
@@ -140,4 +140,10 @@ public function parseAnswerValues($input, $nonDestructive = false) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-date-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/datetimefield.class.php b/inc/fields/datetimefield.class.php
@@ -147,4 +147,10 @@ public function parseAnswerValues($input, $nonDestructive = false) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-datetime-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/descriptionfield.class.php b/inc/fields/descriptionfield.class.php
@@ -124,4 +124,10 @@ public function parseAnswerValues($input, $nonDestructive = false) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-description-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/dropdownfield.class.php b/inc/fields/dropdownfield.class.php
@@ -643,4 +643,10 @@ public function parseObjectProperties(
       $TRANSLATE->setLocale($oldLocale);
       return $content;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-dropdown-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/emailfield.class.php b/inc/fields/emailfield.class.php
@@ -154,4 +154,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-email-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/filefield.class.php b/inc/fields/filefield.class.php
@@ -215,4 +215,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-file-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/floatfield.class.php b/inc/fields/floatfield.class.php
@@ -267,4 +267,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-float-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/glpiselectfield.class.php b/inc/fields/glpiselectfield.class.php
@@ -176,4 +176,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return false;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-glpiselect-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/hiddenfield.class.php b/inc/fields/hiddenfield.class.php
@@ -138,4 +138,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-hidden-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/hostnamefield.class.php b/inc/fields/hostnamefield.class.php
@@ -95,4 +95,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-actor-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/integerfield.class.php b/inc/fields/integerfield.class.php
@@ -267,4 +267,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-integer-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/ipfield.class.php b/inc/fields/ipfield.class.php
@@ -132,4 +132,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-hostname-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/ldapselectfield.class.php b/inc/fields/ldapselectfield.class.php
@@ -270,4 +270,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return false;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-ldapselect-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/multiselectfield.class.php b/inc/fields/multiselectfield.class.php
@@ -311,4 +311,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-multiselect-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/radiosfield.class.php b/inc/fields/radiosfield.class.php
@@ -242,4 +242,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-radios-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/selectfield.class.php b/inc/fields/selectfield.class.php
@@ -155,4 +155,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-select-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/tagfield.class.php b/inc/fields/tagfield.class.php
@@ -208,4 +208,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return false;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-tag-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/textareafield.class.php b/inc/fields/textareafield.class.php
@@ -167,4 +167,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-textarea-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/textfield.class.php b/inc/fields/textfield.class.php
@@ -254,4 +254,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-text-field.png" title="" />';
+   }
 }
diff --git a/inc/fields/urgencyfield.class.php b/inc/fields/urgencyfield.class.php
@@ -198,4 +198,10 @@ public function lessThan($value) {
    public function isAnonymousFormCompatible() {
       return true;
    }
+
+   public function getHtmlIcon() {
+      global $CFG_GLPI;
+
+      return '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-urgency-field.png" title="" />';
+   }
 }
diff --git a/inc/question.class.php b/inc/question.class.php
@@ -191,11 +191,13 @@ public static function showForForm(CommonDBTM $item, $withtemplate = '') {
          $question_number   = count($found_questions);
          $i = 0;
          foreach ($found_questions as $question) {
+            $fieldType = 'PluginFormcreator' . ucfirst($question['fieldtype']) . 'Field';
+            $field = new $fieldType($question);
             $i++;
             echo '<tr class="line' . ($i % 2) . '" id="question_row_' . $question['id'] . '">';
             echo '<td onclick="plugin_formcreator_editQuestion(' . $item->getId() . ', \'' . $token . '\', ' . $question['id'] . ', ' . $section['id'] . ')">';
             echo "<a href='#'>";
-            echo '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/ui-' . $question['fieldtype'] . '-field.png" title="" /> ';
+            echo $field->getHtmlIcon();
             echo $question['name'];
             echo "<a>";
             echo '</td>';