refactor(formanswer): simplify code

pluginsGLPI · Dec 9, 2022 · 4b70dff · 4b70dff
1 parent f61ded1
commit 4b70dff
Showing 1 changed file with 10 additions and 16 deletions.
diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
@@ -1110,29 +1110,23 @@ public function getFullForm($richText = false): string {
          }
 
          // Don't save tags in "full form"
-         if ($question_line['fieldtype'] == 'tag') {
-            continue;
-         }
-
-         if ($question_line['fieldtype'] == 'fields') {
+         if (in_array($question_line['fieldtype'], ['tag', 'fields', 'description'])) {
             continue;
          }
 
          if (!PluginFormcreatorFields::isVisible($fields[$question_line['id']]->getQuestion(), $this->questionFields)) {
             continue;
          }
 
-         if ($question_line['fieldtype'] != 'description') {
-            $question_no++;
-            if ($richText) {
-               $output .= '<div>';
-               $output .= '<b>' . $question_no . ') ##question_' . $question_line['id'] . '## : </b>';
-               $output .= '##answer_' . $question_line['id'] . '##';
-               $output .= '</div>';
-            } else {
-               $output .= $question_no . ') ##question_' . $question_line['id'] . '## : ';
-               $output .= '##answer_' . $question_line['id'] . '##' . $eol . $eol;
-            }
+         $question_no++;
+         if ($richText) {
+            $output .= '<div>';
+            $output .= '<b>' . $question_no . ') ##question_' . $question_line['id'] . '## : </b>';
+            $output .= '##answer_' . $question_line['id'] . '##';
+            $output .= '</div>';
+         } else {
+            $output .= $question_no . ') ##question_' . $question_line['id'] . '## : ';
+            $output .= '##answer_' . $question_line['id'] . '##' . $eol . $eol;
          }
       }