refactor: remove dead code

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Jan 30, 2019 · 91205dc · 91205dc
1 parent e719c8a
commit 91205dc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/inc/fields.class.php b/inc/fields.class.php
@@ -183,8 +183,6 @@ public static function isVisible($id, $fields) {
          }
 
          // TODO: find the best behavior if the question does not exists
-         $conditionQuestion = new PluginFormcreatorQuestion();
-         $conditionQuestion->getFromDB($condition['field']);
          $conditionField = $fields[$condition['field']];
 
          switch ($condition['operator']) {

diff --git a/inc/question_condition.class.php b/inc/question_condition.class.php
@@ -157,6 +157,12 @@ public function export($remove_uuid = false) {
       return $condition;
    }
 
+   /**
+    * get show / hide conditions for a question
+    *
+    * @param int $questionId
+    * @return array
+    */
    public function getConditionsFromQuestion($questionId) {
       global $DB;
 
@@ -271,4 +277,4 @@ public function getConditionHtml($form_id, $questionId = 0, $isFirst = false) {
 
       return $html;
    }
-}
+}