fix(issue): allow null in name column

pluginsGLPI · Jun 20, 2022 · bb32843 · bb32843
1 parent 7741573
commit bb32843
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/install/mysql/plugin_formcreator_empty.sql b/install/mysql/plugin_formcreator_empty.sql
@@ -284,7 +284,7 @@ CREATE TABLE IF NOT EXISTS `glpi_plugin_formcreator_targets_actors` (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci ROW_FORMAT=DYNAMIC;
 CREATE TABLE IF NOT EXISTS `glpi_plugin_formcreator_issues` (
   `id`                    int unsigned  NOT NULL AUTO_INCREMENT,
-  `name`                  varchar(255)  NOT NULL DEFAULT '',
+  `name`                  varchar(255)  NULL DEFAULT NULL,
   `display_id`            varchar(255)  NOT NULL,
   `items_id`              int unsigned  NOT NULL DEFAULT '0',
   `itemtype`              varchar(255)  NOT NULL DEFAULT '',

diff --git a/install/upgrade_to_2.13.php b/install/upgrade_to_2.13.php
@@ -49,6 +49,7 @@ public function upgrade(Migration $migration) {
       $this->addFormVisibility();
       $this->addRequestSourceSetting();
       $this->addEntityOption();
+      $this->fixissues();
    }
 
    public function addEntityOption() {
@@ -317,6 +318,12 @@ public function addDefaultFormListMode() {
       $this->migration->addPostQuery("UPDATE `glpi_plugin_formcreator_entityconfigs` SET `default_form_list_mode`=0 WHERE `entities_id`=0");
    }
 
+   public function fixissues() {
+      $table = 'glpi_plugin_formcreator_issues';
+
+      $this->migration->changeField($table, 'name', 'name', 'string', ['after' => 'id', 'nodefault' => true]);
+   }
+
    public function isResyncIssuesRequiresd() {
       return false;
    }