Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormCreator - Counter to zero #1506

Closed
lolokai opened this issue Sep 26, 2019 · 14 comments
Closed

FormCreator - Counter to zero #1506

lolokai opened this issue Sep 26, 2019 · 14 comments
Assignees
@btry
Labels
bug

Comments

@lolokai
Copy link

lolokai commented Sep 26, 2019

Describe the bug
After an upgrade to the last version (2.8.5) - GLPI 9.4.4 when we go to the catalog view : every counters are at 0 :
image

To Reproduce
Go to the catalog view when you are a Self Service user

Expected behavior
When you click on one of these number : the search returns 0 results but this result is incorrect because tickets exist.
Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 1°
  • Browser Google Chrome
  • Version 77
@btry
Copy link
Collaborator

btry commented Sep 26, 2019

Hi

Could you check if you have sql / php errors in the logs located in files/_logs/php-errors.log and file/_logs/sql-errors.log ?

@btry
Copy link
Collaborator

btry commented Sep 26, 2019

Also which version of Formcreator did you use before the upgrade ?

@btry btry self-assigned this Sep 26, 2019
@lolokai
Copy link
Author

lolokai commented Sep 26, 2019

I have this error (previous version : 2.3.5) :
[2019-09-26 10:58:34] glpiphplog.ERROR: Toolbox::userErrorHandlerNormal() in /var/www/html/glpi/inc/toolbox.class.php line 658
*** PHP Notice(8): Undefined index: totalcount
Backtrace :
plugins/formcreator/inc/issue.class.php:667
plugins/formcreator/inc/wizard.class.php:243 PluginFormcreatorIssue::getTicketSummary()
plugins/formcreator/inc/wizard.class.php:86 PluginFormcreatorWizard::showTicketSummary()
plugins/formcreator/front/issue.php:44 PluginFormcreatorWizard::header()
{"user":"2@GLPI","mem_usage":"0.001", 5.50Mio)"}
[2019-09-26 10:58:34] glpiphplog.ERROR: Toolbox::userErrorHandlerNormal() in /var/www/html/glpi/inc/toolbox.class.php line 658
*** PHP Notice(8): Undefined index: totalcount
Backtrace :
plugins/formcreator/inc/issue.class.php:673
plugins/formcreator/inc/wizard.class.php:243 PluginFormcreatorIssue::getTicketSummary()
plugins/formcreator/inc/wizard.class.php:86 PluginFormcreatorWizard::showTicketSummary()
plugins/formcreator/front/issue.php:44 PluginFormcreatorWizard::header()
{"user":"2@GLPI","mem_usage":"0.001", 5.52Mio)"}
[2019-09-26 10:58:34] glpiphplog.ERROR: Toolbox::userErrorHandlerNormal() in /var/www/html/glpi/inc/toolbox.class.php line 658
*** PHP Notice(8): Undefined index: totalcount
Backtrace :
plugins/formcreator/inc/issue.class.php:679
plugins/formcreator/inc/wizard.class.php:243 PluginFormcreatorIssue::getTicketSummary()
plugins/formcreator/inc/wizard.class.php:86 PluginFormcreatorWizard::showTicketSummary()
plugins/formcreator/front/issue.php:44 PluginFormcreatorWizard::header()
{"user":"2@GLPI","mem_usage":"0.001", 5.54Mio)"}
[2019-09-26 10:58:34] glpiphplog.ERROR: Toolbox::userErrorHandlerNormal() in /var/www/html/glpi/inc/toolbox.class.php line 658
*** PHP Notice(8): Undefined index: totalcount
Backtrace :
plugins/formcreator/inc/issue.class.php:685
plugins/formcreator/inc/wizard.class.php:243 PluginFormcreatorIssue::getTicketSummary()
plugins/formcreator/inc/wizard.class.php:86 PluginFormcreatorWizard::showTicketSummary()
plugins/formcreator/front/issue.php:44 PluginFormcreatorWizard::header()
{"user":"2@GLPI","mem_usage":"0.001", 5.55Mio)"}

@btry
Copy link
Collaborator

btry commented Sep 26, 2019

Thanks, It seems that the error is relevant.

Was your GLPI upgraded also ? If yes, which was your version of GLPI ?

@lolokai
Copy link
Author

lolokai commented Sep 26, 2019

Yes the previous version was GLPI 9.3.1

@btry btry added the bug label Sep 26, 2019
@reinethernal
Copy link

Same bug, upgraded from 9.4.1.1.

@btry
Copy link
Collaborator

btry commented Sep 27, 2019

Hi

Could you confirm that there is an error in sql-errors.log similar to the following ?

[2019-09-27 10:25:25] glpisqllog.ERROR: DBmysql::query() in /home/tbugier/public_html/glpi-94/inc/dbmysql.class.php line 188
  *** MySQL query error:
  SQL: SELECT DISTINCT `glpi_plugin_formcreator_issues`.`id` AS id, 'glpi' AS currentuser,
                        `glpi_plugin_formcreator_issues`.`sub_itemtype`, `glpi_plugin_formcreator_issues`.`entities_id`, `glpi_plugin_formcreator_issues`.`is_recursive`,  GROUP_CONCAT(DISTINCT CONCAT(`glpi_plugin_formcreator_issues`.`name`, '$#$' ,
                                                        `glpi_plugin_formcreator_issues`.`id`) ORDER BY `glpi_plugin_formcreator_issues`.`id`
                                        SEPARATOR '$$##$$') AS `ITEM_PluginFormcreatorIssue_1`,
                           
                            IFNULL(GROUP_CONCAT(DISTINCT CONCAT(IFNULL(`glpi_plugin_formcreator_issues`.`display_id`,
                                                                         '__NULL__'),
                                                   '$#$', `glpi_plugin_formcreator_issues`.`id`) SEPARATOR '$$##$$'), '__NULL__$#$')
                                    AS `ITEM_PluginFormcreatorIssue_1_display_id`, `glpi_plugin_formcreator_issues`.`display_id` AS `ITEM_PluginFormcreatorIssue_2`,  `glpi_plugin_formcreator_issues`.`status` AS `ITEM_PluginFormcreatorIssue_4`,  `glpi_plugin_formcreator_issues`.`date_creation` AS `ITEM_PluginFormcreatorIssue_5`,  `glpi_plugin_formcreator_issues`.`date_mod` AS `ITEM_PluginFormcreatorIssue_6`,  `glpi_entities`.`completename` AS `ITEM_PluginFormcreatorIssue_7`,   `glpi_users_requester_id`.`name` AS `ITEM_PluginFormcreatorIssue_8`,
                        `glpi_users_requester_id`.`realname` AS `ITEM_PluginFormcreatorIssue_8_realname`,
                        `glpi_users_requester_id`.`id`  AS `ITEM_PluginFormcreatorIssue_8_id`,
                        `glpi_users_requester_id`.`firstname` AS `ITEM_PluginFormcreatorIssue_8_firstname` FROM `glpi_plugin_formcreator_issues` LEFT JOIN `glpi_tickets_users`  AS `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`.`tickets_id`
                                                 AND `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`.`type` = 1 ) LEFT JOIN `glpi_tickets_users`  AS `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`.`tickets_id`
                                                 AND `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`.`type` = 3 ) LEFT JOIN `glpi_groups_tickets`  AS `glpi_groups_tickets_d86d1fe2a1ea996e3820de82e6aa57e8`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_groups_tickets_d86d1fe2a1ea996e3820de82e6aa57e8`.`tickets_id`
                                                 AND `glpi_groups_tickets_d86d1fe2a1ea996e3820de82e6aa57e8`.`type` = 3 ) LEFT JOIN `glpi_tickets_users`  AS `glpi_tickets_users_819efb92c8b927b345e489211ec8e43b`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_tickets_users_819efb92c8b927b345e489211ec8e43b`.`tickets_id`
                                                 AND `glpi_tickets_users_819efb92c8b927b345e489211ec8e43b`.`type` = 2 ) LEFT JOIN `glpi_groups_tickets`  AS `glpi_groups_tickets_819efb92c8b927b345e489211ec8e43b`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_groups_tickets_819efb92c8b927b345e489211ec8e43b`.`tickets_id`
                                                 AND `glpi_groups_tickets_819efb92c8b927b345e489211ec8e43b`.`type` = 2 )LEFT JOIN `glpi_entities` 
                                          ON (`glpi_plugin_formcreator_issues`.`entities_id` = `glpi_entities`.`id`
                                              )LEFT JOIN `glpi_users`  AS `glpi_users_requester_id`
                                          ON (`glpi_plugin_formcreator_issues`.`requester_id` = `glpi_users_requester_id`.`id`
                                              ) WHERE ( `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`.users_id = '2'
                                    OR `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`.users_id = '2'
                                    OR `glpi_plugin_formcreator_issues`.`requester_id` = '2')  AND (   `glpi_plugin_formcreator_issues`.`status` IN ('2','3')  AND  (`glpi_users`.`id` = '2')  ) GROUP BY `glpi_plugin_formcreator_issues`.`id` ORDER BY ITEM_PluginFormcreatorIssue_1 ASC 
  Error: Unknown column 'glpi_users.id' in 'where clause'
  Backtrace :
  inc/search.class.php:1246                          
  inc/search.class.php:314                           Search::constructData()
  plugins/formcreator/inc/issue.class.php:666        Search::getDatas()
  plugins/formcreator/inc/wizard.class.php:243       PluginFormcreatorIssue::getTicketSummary()
  plugins/formcreator/inc/wizard.class.php:86        PluginFormcreatorWizard::showTicketSummary()
  plugins/formcreator/front/wizard.php:46            PluginFormcreatorWizard::header()

@btry
Copy link
Collaborator

btry commented Sep 27, 2019

It looks like a recent commit in GLPI 9.4 broke the plugin

glpi-project/glpi#6260

@Dayflare
Copy link

i can confirm this error too. Upgraded from GLPI 9.4.3 to 9.4.4

Error Log:

[2019-09-27 11:34:36] glpisqllog.ERROR: DBmysql::query() in /var/www/html/glpi/inc/dbmysql.class.php line 188
  *** MySQL query error:
  SQL: SELECT DISTINCT `glpi_plugin_formcreator_issues`.`id` AS id, 'MuellerF' AS currentuser,
                        `glpi_plugin_formcreator_issues`.`sub_itemtype`, `glpi_plugin_formcreator_issues`.`entities_id`, `glpi_plugin_formcreator_issues`.`is_recursive`,  GROUP_CONCAT(DISTINCT CONCAT(`glpi_plugin_formcreator_issues`.`name`, '$#$' ,
                                                        `glpi_plugin_formcreator_issues`.`id`) ORDER BY `glpi_plugin_formcreator_issues`.`id`
                                        SEPARATOR '$$##$$') AS `ITEM_PluginFormcreatorIssue_1`,
                           
                            IFNULL(GROUP_CONCAT(DISTINCT CONCAT(IFNULL(`glpi_plugin_formcreator_issues`.`display_id`,
                                                                         '__NULL__'),
                                                   '$#$', `glpi_plugin_formcreator_issues`.`id`) SEPARATOR '$$##$$'), '__NULL__$#$')
                                    AS `ITEM_PluginFormcreatorIssue_1_display_id`, `glpi_plugin_formcreator_issues`.`display_id` AS `ITEM_PluginFormcreatorIssue_2`,  `glpi_plugin_formcreator_issues`.`status` AS `ITEM_PluginFormcreatorIssue_4`,  `glpi_plugin_formcreator_issues`.`date_creation` AS `ITEM_PluginFormcreatorIssue_5`,  `glpi_plugin_formcreator_issues`.`date_mod` AS `ITEM_PluginFormcreatorIssue_6`,  `glpi_entities`.`completename` AS `ITEM_PluginFormcreatorIssue_7`,   `glpi_users_requester_id`.`name` AS `ITEM_PluginFormcreatorIssue_8`,
                        `glpi_users_requester_id`.`realname` AS `ITEM_PluginFormcreatorIssue_8_realname`,
                        `glpi_users_requester_id`.`id`  AS `ITEM_PluginFormcreatorIssue_8_id`,
                        `glpi_users_requester_id`.`firstname` AS `ITEM_PluginFormcreatorIssue_8_firstname`,
                         `glpi_users_validator_id`.`name` AS `ITEM_PluginFormcreatorIssue_9`,
                        `glpi_users_validator_id`.`realname` AS `ITEM_PluginFormcreatorIssue_9_realname`,
                        `glpi_users_validator_id`.`id`  AS `ITEM_PluginFormcreatorIssue_9_id`,
                        `glpi_users_validator_id`.`firstname` AS `ITEM_PluginFormcreatorIssue_9_firstname`,
                         `glpi_users_users_id_validate_0b7a6913865d04cfe94af0bd524943a8`.`name` AS `ITEM_PluginFormcreatorIssue_11`,
                        `glpi_users_users_id_validate_0b7a6913865d04cfe94af0bd524943a8`.`realname` AS `ITEM_PluginFormcreatorIssue_11_realname`,
                        `glpi_users_users_id_validate_0b7a6913865d04cfe94af0bd524943a8`.`id`  AS `ITEM_PluginFormcreatorIssue_11_id`,
                        `glpi_users_users_id_validate_0b7a6913865d04cfe94af0bd524943a8`.`firstname` AS `ITEM_PluginFormcreatorIssue_11_firstname` FROM `glpi_plugin_formcreator_issues` LEFT JOIN `glpi_tickets_users`  AS `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`.`tickets_id`
                                                 AND `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`.`type` = 1 ) LEFT JOIN `glpi_groups_tickets`  AS `glpi_groups_tickets_d1524bb2ea1d461ab90aed3b5f0e7e60`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_groups_tickets_d1524bb2ea1d461ab90aed3b5f0e7e60`.`tickets_id`
                                                 AND `glpi_groups_tickets_d1524bb2ea1d461ab90aed3b5f0e7e60`.`type` = 1 ) LEFT JOIN `glpi_tickets_users`  AS `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`.`tickets_id`
                                                 AND `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`.`type` = 3 ) LEFT JOIN `glpi_groups_tickets`  AS `glpi_groups_tickets_d86d1fe2a1ea996e3820de82e6aa57e8`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_groups_tickets_d86d1fe2a1ea996e3820de82e6aa57e8`.`tickets_id`
                                                 AND `glpi_groups_tickets_d86d1fe2a1ea996e3820de82e6aa57e8`.`type` = 3 ) LEFT JOIN `glpi_tickets_users`  AS `glpi_tickets_users_819efb92c8b927b345e489211ec8e43b`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_tickets_users_819efb92c8b927b345e489211ec8e43b`.`tickets_id`
                                                 AND `glpi_tickets_users_819efb92c8b927b345e489211ec8e43b`.`type` = 2 ) LEFT JOIN `glpi_groups_tickets`  AS `glpi_groups_tickets_819efb92c8b927b345e489211ec8e43b`
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_groups_tickets_819efb92c8b927b345e489211ec8e43b`.`tickets_id`
                                                 AND `glpi_groups_tickets_819efb92c8b927b345e489211ec8e43b`.`type` = 2 ) LEFT JOIN `glpi_ticketvalidations` 
                                             ON (`glpi_plugin_formcreator_issues`.`original_id` = `glpi_ticketvalidations`.`tickets_id`
                                                 )LEFT JOIN `glpi_entities` 
                                          ON (`glpi_plugin_formcreator_issues`.`entities_id` = `glpi_entities`.`id`
                                              )LEFT JOIN `glpi_users`  AS `glpi_users_requester_id`
                                          ON (`glpi_plugin_formcreator_issues`.`requester_id` = `glpi_users_requester_id`.`id`
                                              )LEFT JOIN `glpi_users`  AS `glpi_users_validator_id`
                                          ON (`glpi_plugin_formcreator_issues`.`validator_id` = `glpi_users_validator_id`.`id`
                                              ) LEFT JOIN `glpi_items_tickets`  AS `glpi_items_tickets_98f12cf66606d29f25416b7a7670027d`
                                          ON (`glpi_items_tickets_98f12cf66606d29f25416b7a7670027d`.`itemtype` = 'PluginFormcreatorFormAnswer'
                                              AND `glpi_plugin_formcreator_issues`.`original_id` = `glpi_items_tickets_98f12cf66606d29f25416b7a7670027d`.`items_id` ) LEFT JOIN `glpi_users`  AS `glpi_users_users_id_validate_0b7a6913865d04cfe94af0bd524943a8`
                                          ON (`glpi_ticketvalidations`.`users_id_validate` = `glpi_users_users_id_validate_0b7a6913865d04cfe94af0bd524943a8`.`id`
                                              ) WHERE ( `glpi_tickets_users_d1524bb2ea1d461ab90aed3b5f0e7e60`.users_id = '893'
                                    OR `glpi_tickets_users_d86d1fe2a1ea996e3820de82e6aa57e8`.users_id = '893'
                                    OR `glpi_plugin_formcreator_issues`.`requester_id` = '893' OR `glpi_groups_tickets_d1524bb2ea1d461ab90aed3b5f0e7e60`.`groups_id`
                                             IN (1,224) OR `glpi_groups_tickets_d86d1fe2a1ea996e3820de82e6aa57e8`.`groups_id`
                                             IN (1,224) OR `glpi_ticketvalidations`.`users_id_validate`
                                          = '893')  AND  ( `glpi_plugin_formcreator_issues`.`entities_id` IN ('8')  OR (`glpi_plugin_formcreator_issues`.`is_recursive`='1' AND `glpi_plugin_formcreator_issues`.`entities_id` IN ('0')) )  AND (   `glpi_plugin_formcreator_issues`.`status` IN ('waiting')  AND (`glpi_users`.`id` = '893')  OR `glpi_plugin_formcreator_issues`.`status` IN ('waiting')  AND (`glpi_users_users_id_validate_0b7a6913865d04cfe94af0bd524943a8`.`id` = '893')  ) GROUP BY `glpi_plugin_formcreator_issues`.`id` ORDER BY ITEM_PluginFormcreatorIssue_6 DESC 
  Error: Unknown column 'glpi_users.id' in 'where clause'
  Backtrace :
  inc/search.class.php:1246                          
  inc/search.class.php:98                            Search::constructData()
  inc/search.class.php:80                            Search::showList()
  plugins/formcreator/front/issue.php:61             Search::show()
  {"user":"893@glpi","mem_usage":"0.005\", 3.69Mio)"}

@btry btry mentioned this issue Sep 27, 2019
Merged
@btry
Copy link
Collaborator

btry commented Sep 27, 2019

Hi I found a possible fix; I need to validate it does not breaks something else.

Please test it on a testing environment, (saved searches, some searches you might do in GLPI anywhere.)

@btry
Copy link
Collaborator

btry commented Oct 4, 2019

Hi

Could you feedback about the fix for GLPI ? It should solve the problem.

@lolokai
Copy link
Author

lolokai commented Oct 4, 2019

I confirm : it works perfectly ;)

@reinethernal
Copy link

Works like a charm!

@btry
Copy link
Collaborator

btry commented Oct 4, 2019

Great !

Thank you for your feedback

@btry btry closed this as completed Oct 4, 2019
@btry btry mentioned this issue Apr 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btry btry

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lolokai @btry @reinethernal @Dayflare