Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator is now a requester plugin 2.9 #1545

Closed
reinethernal opened this issue Oct 17, 2019 · 8 comments
Closed

Validator is now a requester plugin 2.9 #1545

reinethernal opened this issue Oct 17, 2019 · 8 comments
Assignees
Labels
Milestone

Comments

@reinethernal
Copy link

Describe the bug
After validating a form validator became a requester.

To Reproduce
Steps to reproduce the behavior:

  1. Validate form
  2. Click on new ticket
  3. See error

Expected behavior
Validator must not be a requester

Screenshots
image

image

@btry
Copy link
Collaborator

btry commented Oct 17, 2019

Hi
Did you observed the same in earlier versions (2.8.x) ?

@btry btry added the bug label Oct 17, 2019
@btry btry self-assigned this Oct 17, 2019
@btry btry added this to the 2.9.0-beta.2 milestone Oct 17, 2019
@reinethernal
Copy link
Author

No, only at that version

@btry
Copy link
Collaborator

btry commented Oct 17, 2019

I'm comapring version 2.8.5 and 2.9.0-beta

I don't see any difference. When a form answer is validated, the validator is logged, then he is the author of the ticket (in the top right corner of the form). Despite this may require an enhancement, both version currently behave the same .

In the following screenshots, "glpi" filled a form, and the answer is validated by "normal"

2.8.5

image

2.9.0 beta

image

@reinethernal
Copy link
Author

Ok. Thank you) Maybe that's not a 'bug' but a 'feature', but how for me, that's confusing

@btry
Copy link
Collaborator

btry commented Oct 18, 2019

I think it is possible to have a better management of the author, but I don"t know how yet. If I need a new column un a table I'll have to do that for the next minor version (2.10)

@btry btry removed this from the 2.9.0-beta.2 milestone Oct 18, 2019
@btry
Copy link
Collaborator

btry commented Oct 18, 2019

Link with #50
Better behavior witrh #1391, but still WIP

btry added a commit to btry/formcreator that referenced this issue Jan 7, 2020
@btry
Copy link
Collaborator

btry commented Jan 7, 2020

Hi @reinethernal

Could you try this fix and feedback ?

@btry btry added this to the 2.9.1 milestone Jan 7, 2020
btry added a commit to btry/formcreator that referenced this issue Jan 10, 2020
btry added a commit that referenced this issue Jan 10, 2020
close #50 #1545

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
@btry btry modified the milestones: 2.9.1, 2.9.2 Jan 14, 2020
@btry
Copy link
Collaborator

btry commented Jan 14, 2020

The fix worked for me. Having no feedback, I guess it will work for you as werll. If not, please open a new issue.

@btry btry closed this as completed Jan 14, 2020
btry added a commit that referenced this issue Jan 5, 2021
close #50 #1545

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants