support 2.9.0 - duplicate crash

[mab18]

Hi,
I try to duplicate a form :

Fatal error: Uncaught GlpiPlugin\Formcreator\Exception\ImportFailureException: failed to add or update the item in /var/www/html/glpi/plugins/formcreator/inc/question.class.php:974 Stack trace:
0 /var/www/html/glpi/plugins/formcreator/inc/section.class.php(272): PluginFormcreatorQuestion::import(Object(PluginFormcreatorLinker), Array, 14)
1 /var/www/html/glpi/plugins/formcreator/inc/form.class.php(2007): PluginFormcreatorSection::import(Object(PluginFormcreatorLinker), Array, 10)
2 /var/www/html/glpi/plugins/formcreator/inc/form.class.php(1502): PluginFormcreatorForm::import(Object(PluginFormcreatorLinker), Array)
3 /var/www/html/glpi/plugins/formcreator/inc/form.class.php(1567): PluginFormcreatorForm->duplicate()
4 /var/www/html/glpi/inc/massiveaction.class.php(990): PluginFormcreatorForm::processMassiveActionsForOneItemtype(Object(MassiveAction), Object(PluginFormcreatorForm), Array)
5 /var/www/html/glpi/inc/massiveaction.class.php(969): MassiveAction->processForSeveralItemtypes()
6 /var/www/html/glpi/front/massi in /var/www/html/glpi/plugins/formcreator/inc/question.class.php on line 974

The form is very partially duplicated :-/

[btry]

Hi

With a simple form, it works. I guess this is specific to your form. Could you find a very simple form where you can reproduce the issue and send its export or describe how to build it ?

EDIT : It is normal that the form is partially duplicated. The plugin cannot revert after a failure.

[mab18]

Hi,

Here is the form I use : (modified ;-) )
export_formcreator_20191217_095700.json.txt

I will try to find the problem in simplify the form...

(note github don't support json extention, it's the reason of .txt at the end)
Edit : (the partial duplication information was for specify the final status. A rollback maybe a day ;-) ?)

[mab18]

Hi,
Attachement is in the precedent post.
Some forms are ok to duplicate...
I have another problem with another form : message is not the same, I create another issue.

[mab18]

I see a problem : I have a string of characters in a question of type "selection" of 97 char. (it's a text and a comment in brackets because it has to be on the same line). If I reduce the line, it's duplicate it and crash later on another thing. But I don't see what.

[btry]

Hi

Brackets ? ok, i'm not sure yet, but this might be the cause of the bug. I'll have a try after i finish my current task.

[mab18]

If I replace braquets by spaces, same thing.
If I reduce the length it crash later, but no idea.

[btry]

The file you shared works fine for me. I can duplicate the form without any issue.

If you try again, you wwill have an incomplete duplicate form. By editing it you will be able to identity the first question missing. look in the original form which is this questin, and give me a screenshot of its settings. The error should be related to its content.

[mab18]

This issue is corrected by #1585
Thank you @btry

[mab18]

I have a question : Why I have the problem and not you ?

[btry]

I don't know yet. Probably a difference between the data in your db compared to mine, despite the effort to have an accurate export / import code.

so, in this issue, remains a duplication bug with your select field of 97 chars, right ?

[mab18]

Ok for maybe differences... not easy I think to have a dev environment AND a test one, AND a ref one... ;-)
Your are right about 97 chars, but, I didn't change the length, so 97 chars seems not to be a problem. I think I changed the test case in suppressing many of last ones by suppress les ' and ( and ) ;-)

[btry]

If you have a backup of the DB before you changed the data, check if the question had a single quote in the columns values or default_values.

If you find one or more, then the fix I added today will very likely fix the bug.

I'm quite sure we can close this issue.

[mab18]

I found the second problem : I have double quote in description !
But duplication is ok now. For me, now, there is no problem with quotes (simple or double) or parentheses, in my context.
Just when, duplicate, #1571 is again present.