[ GLPI 10 rc2 ] [Formcreator 2.13.0-alpha.4] - "Properties" load indefinitely #2682

stdglpi · 2022-04-05T13:18:58Z

I'm dealing with this bug

After creating one form

Going to the paramater "Targets" for a exemple : form to a ticket

if I click on properties it loads indefinitely (seems to have no logs)

btry · 2022-04-05T14:33:12Z

Hi

Open the browser developer tools, then refresh the page. Open the *targets tab and check in the networking tab of the dev tools if you have HTTP response codes >= 300

stdglpi · 2022-04-05T14:51:28Z

do you find something interesting here ?

btry · 2022-04-06T06:13:43Z

Hi

There is a HTTP 500 response code when calling targetticket.form.php.

You should find an error message and its backtrace in the HTTP server's log (by default /var/log/apache2/errors.log for Apache)

stdglpi · 2022-04-06T11:54:26Z

Hello

In fact I have one log in the SQL errors.logs

[2022-04-06 13:51:31] glpisqllog.ERROR: DBmysql::query() in C:\inetpub\wwwroot\glpi\src\DBmysql.php line 367 *** MySQL query error: SQL: SELECT glpi_plugin_formcreator_questions.idASqid, glpi_plugin_formcreator_questions.nameASqname, glpi_plugin_formcreator_sections.idASsid, glpi_plugin_formcreator_sections.nameASsnameFROMglpi_plugin_formcreator_questionsLEFT JOINglpi_plugin_formcreator_sections ON (glpi_plugin_formcreator_questions.plugin_formcreator_sections_id=glpi_plugin_formcreator_sections.id) WHERE (plugin_formcreator_forms_id= '3' ANDfieldtypeIN ('glpiselect') ANDitemtypeIN ('Ticket') ANDdisplay= '0') ORDER BYglpi_plugin_formcreator_sections.order, glpi_plugin_formcreator_questions.row, glpi_plugin_formcreator_questions.col Error: Unknown column 'display' in 'where clause' Backtrace : src\DBmysqlIterator.php:108 src\DBmysql.php:1039 DBmysqlIterator->execute() plugins\formcreator\inc\question.class.php:1022 DBmysql->request() plugins\formcreator\inc\question.class.php:1055 PluginFormcreatorQuestion::getQuestionsFromFormBySection() plugins\formcreator\inc\targetticket.class.php:471 PluginFormcreatorQuestion::dropdownForForm() plugins\formcreator\inc\targetticket.class.php:286 PluginFormcreatorTargetTicket->showCompositeTicketSettings() plugins\formcreator\inc\targetticket.class.php:152 PluginFormcreatorTargetTicket::showProperties() src\CommonGLPI.php:687 PluginFormcreatorTargetTicket::displayTabContentForItem() ajax\common.tabs.php:107 CommonGLPI::displayStandardTab()

btry · 2022-04-06T12:51:44Z

It is possible that this error leads to an PHP error some lines later in the code. IS there really nothing in the HTTP server logs ?

stdglpi · 2022-04-06T15:06:25Z

I have something ! :)

[2022-04-06 16:47:31] glpiphplog.NOTICE: *** PHP Deprecated function (8192): json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in C:\inetpub\wwwroot\glpi\plugins\formcreator\inc\abstractitiltarget.class.php at line 1307
Backtrace :
...rmcreator\inc\abstractitiltarget.class.php:1307 json_decode()
plugins\formcreator\inc\targetticket.class.php:276 PluginFormcreatorAbstractItilTarget->showValidationSettings()
plugins\formcreator\inc\targetticket.class.php:152 PluginFormcreatorTargetTicket::showProperties()
src\CommonGLPI.php:687 PluginFormcreatorTargetTicket::displayTabContentForItem()
ajax\common.tabs.php:107 CommonGLPI::displayStandardTab()

[2022-04-06 16:48:01] glpiphplog.NOTICE: *** PHP Deprecated function (8192): json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in C:\inetpub\wwwroot\glpi\plugins\formcreator\inc\abstractitiltarget.class.php at line 1307
Backtrace :
...rmcreator\inc\abstractitiltarget.class.php:1307 json_decode()
plugins\formcreator\inc\targetticket.class.php:276 PluginFormcreatorAbstractItilTarget->showValidationSettings()
plugins\formcreator\inc\targetticket.class.php:152 PluginFormcreatorTargetTicket::showProperties()
src\CommonGLPI.php:687 PluginFormcreatorTargetTicket::displayTabContentForItem()
ajax\common.tabs.php:107 CommonGLPI::displayStandardTab()

btry · 2022-04-06T17:39:18Z

This is a deprecation warning. I think it is not related to your problem, but I'll search a solution for it.

I need to find a way to reproduce without much clues. Stay tuned

stdglpi · 2022-04-06T18:31:56Z

This is a deprecation warning. I think it is not related to your problem, but I'll search a solution for it.

I need to find a way to reproduce without much clues. Stay tuned

Thx I try to found something tommorow morning

btry · 2022-04-07T06:26:34Z

Hi

Please check the table glpi_plugin_formcreator_targettickets. Do you have a column named commonitil_validation_question ?

stdglpi · 2022-04-07T08:12:52Z

Hi

Please check the table glpi_plugin_formcreator_targettickets. Do you have a column named commonitil_validation_question ?

Hi

btry · 2022-04-07T08:14:13Z

You show the wrong table: this is glpi_plugin_formcreator_targets_actors

SHOW CREATE TABLE `glpi_plugin_formcreator_targettickets`

stdglpi · 2022-04-08T12:43:20Z

@btry hello

sorry, I have only two lines on this table

btry · 2022-04-11T11:26:00Z

Hi

The fix above should solve the SQL query error with bad column display

btry · 2022-04-11T11:27:18Z

Please execute the following query in mysql, and show the result

You show the wrong table: this is glpi_plugin_formcreator_targets_actors

SHOW CREATE TABLE `glpi_plugin_formcreator_targettickets`

stdglpi · 2022-04-11T13:05:29Z

Please execute the following query in mysql, and show the result

You show the wrong table: this is glpi_plugin_formcreator_targets_actors
SHOW CREATE TABLE `glpi_plugin_formcreator_targettickets`

Hello

find bellow the result

I also passed the fix for the bad column display thx !

btry · 2022-04-11T13:07:47Z

Well, the output contains several lines. I don't see the the information I need. Let's do an other way. Browse in phpmyadmin to show the structure of the table. I want to see all columns and their type to check if the table has the expected columns.

btry · 2022-04-11T13:08:24Z

Is the SQL error solved with the fix ?

stdglpi · 2022-04-11T13:21:30Z

@btry

Can you check my PDF here ? https://we.tl/t-bNhNi1sSn0

For the SQL let me 1 hour I test to navigate on GLPI and check the logs again.

btry · 2022-04-11T13:42:54Z

The column is here.

For the SQL query bug, you just need to edit a target ticket having some composition with other tickets.

stdglpi · 2022-04-11T14:09:45Z

@btry seems to be fixed with the SQL query !

I tried to check forms from a basic user (simplified interface) if I click on a form I have this error :

[2022-04-11 16:06:06] glpiphplog.WARNING: *** PHP Warning (2): Undefined array key "formcreator_restrict_form" in C:\inetpub\wwwroot\glpi\plugins\formcreator\inc\form.class.php at line 2499
Backtrace :
plugins\formcreator\front\formdisplay.php:55 PluginFormcreatorForm->canViewForRequest()

[2022-04-11 16:06:06] glpiphplog.WARNING: *** PHP Warning (2): foreach() argument must be of type array|object, null given in C:\inetpub\wwwroot\glpi\plugins\formcreator\inc\form.class.php at line 2499
Backtrace :
plugins\formcreator\front\formdisplay.php:55 PluginFormcreatorForm->canViewForRequest()

btry · 2022-04-11T14:15:28Z

Thank you, the fix has been merged. Now try #2696 and feedback. Itr should solve this problem as well

stdglpi · 2022-04-11T14:34:09Z

Thank you, the fix has been merged. Now try #2696 and feedback. Itr should solve this problem as well

problem with users fixed with this fix

thx

btry · 2022-04-12T06:37:40Z

Hi

I think we can close this issue now. Thank you for your feedbacks !

stdglpi · 2022-04-12T15:50:38Z

@btry sorry for the missunderstanding the problem with the SQL errors is fixed.

But, the menu properties is always "loading" see here for example.

https://we.tl/t-eRdLEGB4O5

thx

stdglpi · 2022-04-12T16:04:08Z

@btry sorry for the missunderstanding the problem with the SQL errors is fixed.

But, the menu properties is always "loading" see here for example.

https://we.tl/t-eRdLEGB4O5

thx

I have this in the php logs

[2022-04-12 16:39:18] glpiphplog.NOTICE: *** PHP Deprecated function (8192): json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in C:\inetpub\wwwroot\glpi\plugins\formcreator\inc\abstractitiltarget.class.php at line 1307
Backtrace :
...rmcreator\inc\abstractitiltarget.class.php:1307 json_decode()
plugins\formcreator\inc\targetticket.class.php:276 PluginFormcreatorAbstractItilTarget->showValidationSettings()
plugins\formcreator\inc\targetticket.class.php:152 PluginFormcreatorTargetTicket::showProperties()
src\CommonGLPI.php:687 PluginFormcreatorTargetTicket::displayTabContentForItem()
ajax\common.tabs.php:107 CommonGLPI::displayStandardTab()

[2022-04-12 16:58:20] glpiphplog.NOTICE: *** PHP Deprecated function (8192): json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in C:\inetpub\wwwroot\glpi\plugins\formcreator\inc\abstractitiltarget.class.php at line 1307
Backtrace :
...rmcreator\inc\abstractitiltarget.class.php:1307 json_decode()
plugins\formcreator\inc\targetticket.class.php:276 PluginFormcreatorAbstractItilTarget->showValidationSettings()
plugins\formcreator\inc\targetticket.class.php:152 PluginFormcreatorTargetTicket::showProperties()
src\CommonGLPI.php:687 PluginFormcreatorTargetTicket::displayTabContentForItem()
ajax\common.tabs.php:107 CommonGLPI::displayStandardTab()

btry · 2022-04-12T19:38:11Z

Hi

Open again the developer tools of the browser, reproduce the problem, then show the content of the console tab. Do you have JS errors ?

stdglpi · 2022-04-12T19:58:41Z

@btry

On MS edge

btry · 2022-04-13T06:18:00Z

Hi

We are back (or we are still) facing a fatal error.

If your HTTP server is Apache, you have probably a backtrace in /var/log/apache2/errors.log.

If your HTTP server is nginx you have probably a backtrace in /var/log/nginx/errors.log.

With more specific configurations of those HTTP servers the logs may be actually elsewhere. Check your config if needed.

btry · 2022-04-13T06:26:23Z

The above fix should solve the deprecation notice related to json_decode (#2682 (comment))

I don't expect it will solve the HTTP 500. I need the backtrace to have more clues.

stdglpi · 2022-04-13T08:07:08Z

@btry good news ! problem solved :) i'm able to access to properties now.

btry · 2022-04-13T08:08:37Z

The fix #2699 solved the problem ?

stdglpi · 2022-04-13T08:14:13Z

The fix #2699 solved the problem ?

Yes just after apply this fix I tried to go to "target then "properties" and now it's functional.

I had nothing in the PHP errors, just the "Json_decode" error in php_errors in GLPI folders.

[2022-04-12 16:39:18] glpiphplog.NOTICE: *** PHP Deprecated function (8192): json_decode(): Passing null to parameter #1 ($json) of type string is deprecated in C:\inetpub\wwwroot\glpi\plugins\formcreator\inc\abstractitiltarget.class.php at line 1307
Backtrace :
...rmcreator\inc\abstractitiltarget.class.php:1307 json_decode()
plugins\formcreator\inc\targetticket.class.php:276 PluginFormcreatorAbstractItilTarget->showValidationSettings()
plugins\formcreator\inc\targetticket.class.php:152 PluginFormcreatorTargetTicket::showProperties()
src\CommonGLPI.php:687 PluginFormcreatorTargetTicket::displayTabContentForItem()
ajax\common.tabs.php:107 CommonGLPI::displayStandardTab()

btry · 2022-04-13T08:16:14Z

I think that your log entry comes from glpi/files/_log/php-errors.log, am I right ?

stdglpi · 2022-04-13T08:32:09Z

yes
\wwwroot\glpi\files_log\php-errors.log

Nothing on log about Php manager

btry · 2022-04-13T08:33:33Z

OK, then we can close.

Thank you for your feedback.

btry mentioned this issue Apr 11, 2022

Composite ticket settings #2694

Merged

btry mentioned this issue Apr 11, 2022

Check hook before using it #2696

Merged

btry closed this as completed Apr 12, 2022

btry added the bug label Apr 12, 2022

btry added this to the 2.13.0 milestone Apr 12, 2022

btry reopened this Apr 12, 2022

btry mentioned this issue Apr 13, 2022

Json_decode deprecated null support #2699

Merged

btry closed this as completed Apr 13, 2022

[ GLPI 10 rc2 ] [Formcreator 2.13.0-alpha.4] - "Properties" load indefinitely #2682

[ GLPI 10 rc2 ] [Formcreator 2.13.0-alpha.4] - "Properties" load indefinitely #2682

Comments

stdglpi commented Apr 5, 2022

btry commented Apr 5, 2022

stdglpi commented Apr 5, 2022

btry commented Apr 6, 2022

stdglpi commented Apr 6, 2022

btry commented Apr 6, 2022

stdglpi commented Apr 6, 2022

btry commented Apr 6, 2022

stdglpi commented Apr 6, 2022

btry commented Apr 7, 2022

stdglpi commented Apr 7, 2022

btry commented Apr 7, 2022 • edited Loading

stdglpi commented Apr 8, 2022

btry commented Apr 11, 2022

btry commented Apr 11, 2022 • edited Loading

stdglpi commented Apr 11, 2022

btry commented Apr 11, 2022

btry commented Apr 11, 2022

stdglpi commented Apr 11, 2022

btry commented Apr 11, 2022

stdglpi commented Apr 11, 2022

btry commented Apr 11, 2022

stdglpi commented Apr 11, 2022

btry commented Apr 12, 2022

stdglpi commented Apr 12, 2022

stdglpi commented Apr 12, 2022

btry commented Apr 12, 2022

stdglpi commented Apr 12, 2022 • edited Loading

btry commented Apr 13, 2022

btry commented Apr 13, 2022

stdglpi commented Apr 13, 2022

btry commented Apr 13, 2022

stdglpi commented Apr 13, 2022

btry commented Apr 13, 2022

stdglpi commented Apr 13, 2022

btry commented Apr 13, 2022

btry commented Apr 7, 2022 •

edited

Loading

btry commented Apr 11, 2022 •

edited

Loading

stdglpi commented Apr 12, 2022 •

edited

Loading