Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Location error on form opening #795

Closed
kleverson4g opened this issue Oct 17, 2017 · 14 comments · Fixed by #802
Closed

Bug Location error on form opening #795

kleverson4g opened this issue Oct 17, 2017 · 14 comments · Fixed by #802
Assignees
Labels
Milestone

Comments

@kleverson4g
Copy link

Every time the user opens a call through the form, it ignores the existing location reprieve in glpi and does not inform the called which location of the user, this test was performed in version 9.1.6 of glpi and in the latest version of plugin formcreator.

@btry
Copy link
Collaborator

btry commented Oct 17, 2017

Hi

To be sure I understand: do you mean you expect the location of a user to be assigned to a generated ticket ?

image

image

@kleverson4g
Copy link
Author

A: That! at the time the form, which has a question that asks what the location? and the answer is through a ticket location rule that already exists by default in glpi.
when I send the form does not appear the location of the user that is like the image you sent me here.

@btry
Copy link
Collaborator

btry commented Oct 18, 2017

An encoding issue was solved recently in the future 2.6.1 version of the plugin, which impacted the rules engine in similar cases.

Please consider testing GLPI 9.2 with the develop branch of the plugin to check if the issue still occurs.

Versions of the plugin for GLPI < 9.2 reached end of life and are no longer maintained (actually you're probably using the last version of the plugin which is compatible with your instance of GLPI: it is version 2.5.2, and it is no longer the lastest as 2.6.0 is out).

@kleverson4g
Copy link
Author

This has already been tested, so I'm still not sure how to migrate to version 9.2, I would like to continue using 9.1.6, can you correct for this version?
Thank you and understand that it is not only I who suffer from this and yes several users.
Thank you very much

btry added a commit to btry/formcreator that referenced this issue Oct 18, 2017
if a user has a location and submits a form the business rules to propagate location of the user
on the  generated ticket does not works

fix pluginsGLPI#795
@btry
Copy link
Collaborator

btry commented Oct 18, 2017

Hi

I think I got the issue. Please try the patch in #802 and feedback. It worked successfully for me.

@btry
Copy link
Collaborator

btry commented Oct 18, 2017

Also, please note this will work only of the generated ticket has only one requester. If there are several requesters, the location will not be copied from any requester.

This is by choice because I cannot guess which requester should be userd as "source". Using the first requester is an option but this introduces a special meaning for him which seems in my opinion a source of headache for users.

@btry btry added the bug label Oct 18, 2017
@btry btry self-assigned this Oct 18, 2017
@btry btry added this to the 2.6.1 milestone Oct 18, 2017
@btry
Copy link
Collaborator

btry commented Oct 18, 2017

A final note as you answered while I was searching for your bug.

Currently there is no plan to release a new version of 2.5.x, but the code causing you trouble did not changed (or very few) between version 2.5.x and 2.6.0. This makes the patch easily backportable to versions 2.5.x.

Feel free to keep a patched version of the plugin, the best would be by forking the repository and cherry-pick the commits of the patch.

@kleverson4g
Copy link
Author

I can not change it! if possible
Can you please send me this edited file by email?
kleverson4g@gmail.com

@btry
Copy link
Collaborator

btry commented Oct 18, 2017

Please confirm you use the release 2.5.2 and I'll send you the patched file.

@kleverson4g
Copy link
Author

Yes, I'm in this version.
thank you

btry added a commit to btry/formcreator that referenced this issue Oct 18, 2017
if a user has a location and submits a form the business rules to propagate location of the user
on the  generated ticket does not works

fix pluginsGLPI#795
@btry
Copy link
Collaborator

btry commented Oct 18, 2017

You can download the patches file from this link.

https://raw.githubusercontent.com/btry/formcreator/feature/795_for_2-5-2/inc/targetticket.class.php

Replace the file with the patched one, test and feedback.

@kleverson4g
Copy link
Author

Many thanks worked out perfectly
God bless.

@btry
Copy link
Collaborator

btry commented Oct 18, 2017

Thank you for your feedback. Please keep carefully a copy of the plugin with the patch. From time to time I cleanup obsolete data in my fork, and the download URL will die.

I heavily recommend you to consider update to GLPI 9.2. You said you're unsure about how to migrate to GLPI 9.2. If you need help you may :

@btry btry closed this as completed Oct 18, 2017
btry added a commit to btry/formcreator that referenced this issue Oct 19, 2017
if a user has a location and submits a form the business rules to propagate location of the user
on the  generated ticket does not works

fix pluginsGLPI#795
@mrcssilvasouza
Copy link

Dear,

I use GLPI 9.1.3 and plugin 2.5.2 and it did not work with this change. Utlizo or GLPI 9.1.3 for being the only stable version.

btry added a commit that referenced this issue Oct 24, 2017
if a user has a location and submits a form the business rules to propagate location of the user
on the  generated ticket does not works

fix #795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants