-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Location error on form opening #795
Comments
A: That! at the time the form, which has a question that asks what the location? and the answer is through a ticket location rule that already exists by default in glpi. |
An encoding issue was solved recently in the future 2.6.1 version of the plugin, which impacted the rules engine in similar cases. Please consider testing GLPI 9.2 with the develop branch of the plugin to check if the issue still occurs. Versions of the plugin for GLPI < 9.2 reached end of life and are no longer maintained (actually you're probably using the last version of the plugin which is compatible with your instance of GLPI: it is version 2.5.2, and it is no longer the lastest as 2.6.0 is out). |
This has already been tested, so I'm still not sure how to migrate to version 9.2, I would like to continue using 9.1.6, can you correct for this version? |
if a user has a location and submits a form the business rules to propagate location of the user on the generated ticket does not works fix pluginsGLPI#795
Hi I think I got the issue. Please try the patch in #802 and feedback. It worked successfully for me. |
Also, please note this will work only of the generated ticket has only one requester. If there are several requesters, the location will not be copied from any requester. This is by choice because I cannot guess which requester should be userd as "source". Using the first requester is an option but this introduces a special meaning for him which seems in my opinion a source of headache for users. |
A final note as you answered while I was searching for your bug. Currently there is no plan to release a new version of 2.5.x, but the code causing you trouble did not changed (or very few) between version 2.5.x and 2.6.0. This makes the patch easily backportable to versions 2.5.x. Feel free to keep a patched version of the plugin, the best would be by forking the repository and cherry-pick the commits of the patch. |
I can not change it! if possible |
Please confirm you use the release 2.5.2 and I'll send you the patched file. |
Yes, I'm in this version. |
if a user has a location and submits a form the business rules to propagate location of the user on the generated ticket does not works fix pluginsGLPI#795
You can download the patches file from this link. https://raw.githubusercontent.com/btry/formcreator/feature/795_for_2-5-2/inc/targetticket.class.php Replace the file with the patched one, test and feedback. |
Many thanks worked out perfectly |
Thank you for your feedback. Please keep carefully a copy of the plugin with the patch. From time to time I cleanup obsolete data in my fork, and the download URL will die. I heavily recommend you to consider update to GLPI 9.2. You said you're unsure about how to migrate to GLPI 9.2. If you need help you may :
|
if a user has a location and submits a form the business rules to propagate location of the user on the generated ticket does not works fix pluginsGLPI#795
Dear, I use GLPI 9.1.3 and plugin 2.5.2 and it did not work with this change. Utlizo or GLPI 9.1.3 for being the only stable version. |
if a user has a location and submits a form the business rules to propagate location of the user on the generated ticket does not works fix #795
Every time the user opens a call through the form, it ignores the existing location reprieve in glpi and does not inform the called which location of the user, this test was performed in version 9.1.6 of glpi and in the latest version of plugin formcreator.
The text was updated successfully, but these errors were encountered: