Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translantion keys missing #872

Closed
gfernandez-me opened this issue Dec 29, 2017 · 12 comments · Fixed by #910
Closed

Translantion keys missing #872

gfernandez-me opened this issue Dec 29, 2017 · 12 comments · Fixed by #910
Assignees
Milestone

Comments

@gfernandez-me
Copy link

In pt-BR locale doesn't have some keys

examples:

#: inc/form.class.php:122
msgid "Homepage"
msgstr ""

#: inc/form.class.php:130
msgid "Access"
msgstr ""
@gfernandez-me
Copy link
Author

And pot file is outdated and dont have all keys

@btry
Copy link
Collaborator

btry commented Dec 29, 2017

Hi

You should use Transifex to localize the plugin.

You may also use the features provided by Robo.li and the php script RoboFile.php to update the pot file.

clone the project with GIT.
Ensure you're on the develop branch.
run composer install
run vendor/bin/robo locales:extract
use the updated POT file to create your new language

Once translated, submit a pull request with your new language file.

@btry btry added the question label Dec 29, 2017
@btry
Copy link
Collaborator

btry commented Dec 29, 2017

I updated the locales right now. I hope this will help you.

@gfernandez-me
Copy link
Author

I cant translate all strings on transifex
I sent as a suggestion the ones I could not translate

@btry
Copy link
Collaborator

btry commented Jan 2, 2018

Hi

I'm currently preparing the next release, then your contribution will be included. Thank you very much.

If you cannot translate some strings, you may leave them empty, in the hope you find a solution later, or someone else contribute. As long as 70% of the languge is translated, the language will be used. Not translated strings will remain in english.

Thank you again.

@gfernandez-me
Copy link
Author

The save button is locked for some translations.
That's why I can not translate everything.

I've sent suggestions in these cases.

@gfernandez-me
Copy link
Author

Transifex is updated with new keys?

@btry
Copy link
Collaborator

btry commented Jan 2, 2018

The locales should be updated with the fix for #873 . I think this will help you.

@gfernandez-me
Copy link
Author

clone the project with GIT.
Ensure you're on the develop branch.
run composer install
run vendor/bin/robo locales:extract
use the updated POT file to create your new language

I did this and the translation key does not appear

$tab[] = [ 'id' => '9', 'table' => $this->getTable(), 'field' => 'access_rights', 'name' => __('Access'), 'datatype' => 'specific', 'searchtype' => [ '0' => 'equals', '1' => 'notequals' ], 'massiveaction' => true ];

Access key dont appear in glpi.pot file

@btry
Copy link
Collaborator

btry commented Jan 2, 2018

When this is possible, the plugin reuses locales in GLPI itsenf, then __('Access') refers to a locale available in GLPI.

I'm checking, and it seems this string does not exists in GLPI 9.2. This is either a mistake in the plugin, either because the string disappeared in GLPI. I'll do a patch for this and share here.

@btry btry added the bug label Jan 2, 2018
@btry btry self-assigned this Jan 2, 2018
@btry btry added this to the 2.7.0 milestone Jan 2, 2018
btry added a commit to btry/formcreator that referenced this issue Feb 12, 2018
btry added a commit that referenced this issue Feb 13, 2018
@btry
Copy link
Collaborator

btry commented Mar 5, 2018

Hi @Hotdesc

Do you still have missing keys with version 2.6.2 ? I wish to close this issue.

@btry
Copy link
Collaborator

btry commented Mar 26, 2018

Hi

Having no feedback, I guess the issue is solved. If not, please open a new ticket.

@btry btry closed this as completed Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants