Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6.2] Useless backslashs in ticket title #951

Closed
nqb opened this issue Mar 27, 2018 · 4 comments · Fixed by #958
Closed

[2.6.2] Useless backslashs in ticket title #951

nqb opened this issue Mar 27, 2018 · 4 comments · Fixed by #958
Assignees
Labels
Milestone

Comments

@nqb
Copy link

nqb commented Mar 27, 2018

Hello,

At @btry's request in #922, I open this issue.

When you use characters like "or ' as answer in a form and use this answer as ticket title, you have useless backslashs in ticket title :
useless_backslashs

Steps to reproduce :

  1. Create a form "Test" with a section and a question (type = text)
  2. Define a destination called "MyDestination" (type=ticket)
  3. Set "Ticket title" to ##answer_X## with X, ID of your answer
  4. Save your form
  5. Fill you form
    • Answer to your question with "Router doesn't work"
    • Send form
@btry btry self-assigned this Mar 27, 2018
@btry btry added the bug label Mar 27, 2018
@btry btry added this to the 2.6.3 milestone Mar 27, 2018
btry added a commit to btry/formcreator that referenced this issue Apr 3, 2018
@btry
Copy link
Collaborator

btry commented Apr 3, 2018

Hi

Can you test the above PR please ?

btry added a commit that referenced this issue Apr 9, 2018
@btry
Copy link
Collaborator

btry commented Apr 9, 2018

Positive feedback from a user impacted by the issue.

@btry btry closed this as completed Apr 9, 2018
@ASLLR
Copy link

ASLLR commented Jan 3, 2019

Hi everyone,

i reproduce that issue in formcreator 2.6.5 with GLPI 9.3.3. I think is a regression.

This issue was solved and tested with formcreator 2.6.3 with GLPI 9.2.3

That's exactly the same thing, with this ' and this "

capture

@btry
Copy link
Collaborator

btry commented Jan 3, 2019

Hi

I'm aware about regressions introduced in 2.6.5. Unfortunately I failed to solve some rendering issue without breaking something else. This is due to a technical debt I was progressively removing since 2.5.x.

This technical debt was completely removed in the version 2.7.0 (still in progress), and results seems very good. Feel free to evaluate it (branch develop). A beta was released, and some bugfixes are already added (mostly in the upgrade process )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants