Restrict available LDAP servers. #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
requested changes
Jun 22, 2019
cosmedd
force-pushed
the
feature/restrict_available_ldap_servers
branch
from
b088878 to
ebead94
Compare
|
Requested changes addressed. Thanks for the review, @btry! |
You can view any available LDAP if you have access to the root entity. Otherwise, only the LDAP configured as the default for the current entity is displayed.
cosmedd
force-pushed
the
feature/restrict_available_ldap_servers
branch
3 times, most recently
from
b088878 to
8eb49f9
Compare
|
Well, I do not know if I should do something... Github keeps showing "Changes requested" and "Merging can be performed automatically once the requested changes are addressed." |
|
Hi This is normal that the status remains "changes requested". I need to review your changes again, then update the status. Please be patient until I review the PR again. |
btry
approved these changes
Jun 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
At work, we found a issue with your plugin. We realized that a new client that started using our GLPI could see and use any LDAP configured through the "LDAP Select" type.
This means that any client, with enough privileges in his entity, can see/use our LDAP and any LDAP of other clients.
We quickly implement an workaround based on many assumptions. There is probably a better way to fix this problem but I provide this pull request in case it helps someone or if you want to use it as a starting point.
Changes description
You can view any available LDAP if you have access
to the root entity.
Otherwise, only the LDAP configured as the default
for the current entity is displayed.