Prevent useless DB queries on plugins state checks #2886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
task/save-db-queries
branch
from
e9c0c81 to
b47aa95
Compare
btry
previously approved these changes
Jul 25, 2022
cedric-anne
force-pushed
the
task/save-db-queries
branch
2 times, most recently
from
0c01d56 to
6645f2b
Compare
btry
previously approved these changes
Jul 25, 2022
btry
force-pushed
the
task/save-db-queries
branch
from
6645f2b to
c382af2
Compare
btry
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
Calling
Plugin::isInstalled()prior toPlugin::isPluginActive()/Plugin::isActivated()is useless, as an active plugin is de facto installed. Thus, combining these checks on plugins that are not activated will generate 2 queries, instead of 1 if check is done only on active state.Checklist
Please check if your PR fulfills the following specifications:
Tests for the changes have been added(should not be required)Docs have been added/updated(no impact on docs)References
Closes #N/A