Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust dashboard widget height #3490

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

ccailly
Copy link

@ccailly ccailly commented Apr 9, 2024

Changes description

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

References

Closes #N/A

Correct dashboard widget height in install.php.
Previous pull request, #3306 refactored UI of widgets but missed updating install.php.
A subsequent commit updated install.php but set widget height to 1 instead of the correct value 2.

This PR fixes the widget height value to 2.

@ccailly ccailly requested a review from Rom1-B April 9, 2024 13:27
@ccailly ccailly self-assigned this Apr 9, 2024
@ccailly ccailly added the bug label Apr 9, 2024
@@ -0,0 +1,79 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems simpler and less risky not to resize at all at the update, neither in this version nor in 2.13.7.

Copy link
Collaborator

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To upgrade to version 2.13.0 the version constant in setup.php must be up to date. Also in install.php there is a matrix which modelizes versions sequence It needs a new entry 2.13.9 => 2.13.10.

Also, I don't expect to release a new version as the plugin reached it end of life and we are implementing forms in GLPI core (v11).

@ccailly
Copy link
Author

ccailly commented Apr 12, 2024

As discussed with @Rom1-B above and IRL, it's probably wiser not to change the widget size during an update.
It's possible that some users may have manually modified their widgets, so only new installations of the plugin will benefit from the new widget size.

@btry
Copy link
Collaborator

btry commented Apr 12, 2024

Hi

As discussed with @Rom1-B above and IRL, it's probably wiser not to change the widget size during an update.
It's possible that some users may have manually modified their widgets, so only new installations of the plugin will benefit from the new widget size.

Actually, the plugin takes measures to prevent users to modify its mini dashboard. Noone should be able to modify it (neither super-admins). This is why it should be safe to modify it programmatically

Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @btry.

The resizeWidgets function must not be deleted.

@ccailly ccailly force-pushed the fix/dashboard-widgets-height branch from ff98a57 to f3891f0 Compare April 22, 2024 13:06
@btry btry merged commit f6d63ea into pluginsGLPI:support/2.13.0 Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants