-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust dashboard widget height #3490
fix: adjust dashboard widget height #3490
Conversation
@@ -0,0 +1,79 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems simpler and less risky not to resize at all at the update, neither in this version nor in 2.13.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To upgrade to version 2.13.0 the version constant in setup.php must be up to date. Also in install.php there is a matrix which modelizes versions sequence It needs a new entry 2.13.9 => 2.13.10.
Also, I don't expect to release a new version as the plugin reached it end of life and we are implementing forms in GLPI core (v11).
As discussed with @Rom1-B above and IRL, it's probably wiser not to change the widget size during an update. |
Hi
Actually, the plugin takes measures to prevent users to modify its mini dashboard. Noone should be able to modify it (neither super-admins). This is why it should be safe to modify it programmatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @btry.
The resizeWidgets
function must not be deleted.
ff98a57
to
f3891f0
Compare
Changes description
Checklist
Please check if your PR fulfills the following specifications:
References
Closes #N/A
Correct dashboard widget height in
install.php
.Previous pull request, #3306 refactored UI of widgets but missed updating install.php.
A subsequent commit updated
install.php
but set widget height to 1 instead of the correct value 2.This PR fixes the widget height value to 2.