fix(ui): pqselect enabled not loaded every time it is needed #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
commented
Oct 3, 2017
| @@ -451,7 +451,6 @@ public function showForm($ID, $options=[]) { | |||
| document.getElementById("validators_users").style.display = "none"; | |||
| document.getElementById("validators_groups").style.display = "none"; | |||
| } | |||
| fcInitMultiSelect(); | |||
There was a problem hiding this comment.
I think this is useless to init pqselect here
btry
commented
Oct 3, 2017
| // === Add better multi-select on form configuration validators === | ||
| // initialize the pqSelect widget. | ||
| fcInitMultiSelect(); | ||
|
|
||
| $('#tabspanel + div.ui-tabs').on("tabsload", function( event, ui ) { |
There was a problem hiding this comment.
moving the event handler out of fcInitMultiSelect() because the implemetation does not fully match the name of the function.
orthagh
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify code
ensure pqselect is loaded when a HTML page is loaded as well as when a tab is loaded.
Repairs the UI issue on validator user / group components