Skip to content

Fix dynamic properties and png rendering deprecations #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Vireth4114
Copy link

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
    closes Fixes deprecated dynamic property in baseclass.class.php and helpdeskplus.class.php #273 (most of the deprecated fields were fixed beforehand, but close_date, slaok and slako weren't).
  • Here is a brief description of what this PR does
    • Fixes a few dynamic property deprecation
    • Fixes strftime deprecations
    • Fixes png related deprecations (most are float to int implicit conversion that was deprecated in php 8.1, and a removed argument in imagefilledpolygon() )

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appart my comment.

@Vireth4114
Copy link
Author

I switched the displayed date in notification target to an IntlDateFormatter to accommodate localization. (And I also used the locale's "from %s to %s" instead of raw "du/au")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixes deprecated dynamic property in baseclass.class.php and helpdeskplus.class.php
3 participants