Restrict extra-keys schema in the map spec #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix [issue #16 in schema-generators] (plumatic/schema-generators#16), by wrapping any extra-keys schema in maps in a s/conditional that asserts that none of the extra keys can be equal to any explicit key in the map. This arguably reflects the real meaning of the extra-key entries, and in any case solves the schema-generators problem (when generated extra keys collide with explicit keys) and doesn't seem to cause any problems.
|
This was already discussed here, so I will just merge this when the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issue #16 in schema-generators,
by wrapping any extra-keys schema in maps in a
s/conditional that asserts that none of the extra
keys can be equal to any explicit key in the map.
This arguably reflects the real meaning of the
extra-key entries, and in any case solves the
schema-generators problem (when generated extra
keys collide with explicit keys) and doesn't
seem to cause any problems.