ves regtests failing in GH Actions for Intel: reduce by one more digit #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocamilloni
added a commit
that referenced
this pull request
Nov 30, 2023
carlocamilloni
added a commit
that referenced
this pull request
Dec 1, 2023
fixes #976 related to #999 * test intel CI * switch to the new default intel compilers * fix for CC * decrease accuracy of rc-cs2backbone regtest * reduced precision of ves regtests * Revert "reduced precision of ves regtests" This reverts commit 272ff40. * decreased accuracy of ermsd derivates btw how are they so noisy? * Revert "decreased accuracy of ermsd derivates" This reverts commit 8153e68. * reduced precision of ermsd derivatives I am afraid that they are almost useless now * fix regtest comparison with +-nan * ifx is not found in intel CI revert to ifort * improve nan comparison fortran intel compiler is not yet well configured * more ifx test * updated intel compiler installation * now it intel compilers should work properly * simplified the nan comparison for the regtests * ves regtests: reduce by one more (#995) (#997) Co-authored-by: Omar Valsson <omar.valsson@gmail.com> * further reduced precision ves regtest * more ves * reset * reset * there is an issue with many xyz file in our regtests because they do not define a box but the parser was going on without errors. now this is fixed but I think we could do it better * work around for missing boxes in xyz file of multiple regtests * astyle --------- Co-authored-by: Omar Valsson <omar.valsson@gmail.com> Co-authored-by: Giovanni Bussi <giovanni.bussi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Concerning #990: reduce regtests by one more digit for
Target release
I would like my code to appear in release master
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests