Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prep next release #1654

Merged
merged 3 commits into from
Dec 6, 2024
Merged

prep next release #1654

merged 3 commits into from
Dec 6, 2024

Conversation

michaeljguarino
Copy link
Member

@michaeljguarino michaeljguarino commented Dec 5, 2024 •
edited
Loading

  • tweaks for service catalog
  • need to add catalogRef to PRA crd
  • add some more necessary queries for vuln view

Test Plan

e2e

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Dec 5, 2024
@michaeljguarino michaeljguarino requested review from a team December 5, 2024 17:33
@michaeljguarino michaeljguarino force-pushed the prep-0.40.3 branch 5 times, most recently from c9cb118 to 5f69553 Compare December 5, 2024 22:28
@michaeljguarino
prep next release
1cbb936 
* tweaks for service catalog
* ...
@michaeljguarino michaeljguarino force-pushed the prep-0.40.3 branch 2 times, most recently from 1fb2fcd to 3ef8240 Compare December 6, 2024 08:15
maciaszczykm
maciaszczykm approved these changes Dec 6, 2024
View reviewed changes
assets/src/components/layout/Sidebar.tsx
expandedLabel: 'Service catalog',
icon: <CatalogIcon />,
path: CATALOGS_ABS_PATH,
hotkeys: ['2'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number should be updated I think.

@michaeljguarino michaeljguarino merged commit 704d673 into master Dec 6, 2024
16 checks passed
@michaeljguarino michaeljguarino deleted the prep-0.40.3 branch December 6, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljguarino @maciaszczykm