Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make global service delete cascade by default #1672

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Make global service delete cascade by default #1672

merged 1 commit into from
Dec 13, 2024

Conversation

michaeljguarino
Copy link
Member

Also added metrics for stack failures

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Dec 12, 2024
@michaeljguarino michaeljguarino requested a review from a team December 12, 2024 13:16
@michaeljguarino
Make global service delete cascade by default
d4a9f1e 
Also added metrics for stack failures
@michaeljguarino michaeljguarino merged commit f5d3504 into master Dec 13, 2024
8 checks passed
@michaeljguarino michaeljguarino deleted the add-gs-defaults branch December 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljguarino @maciaszczykm