-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault private ingress #437
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
vault/helm/vault/values.yaml.tpl
Outdated
@@ -43,7 +43,11 @@ vault: | |||
cert-manager.io/cluster-issuer: letsencrypt-prod | |||
nginx.ingress.kubernetes.io/force-ssl-redirect: "true" | |||
nginx.ingress.kubernetes.io/use-regex: "true" | |||
{{- if not .Values.exposePrivate }} | |||
ingressClassName: nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of these values should actually be moved down to values.yaml since the current setup prevents reconfiguration. Really we should have nginx as the default there then overwrite with:
{{ if .Values.exposePrivate }}
ingressClassName: internal-nginx
{{ end }}
in values.yaml.tpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I moved the values to values.yaml.tpl. Ihad to leave also the else statement, as otherwise the className gets undefined.
- moved from tpl to value.yaml ingress values - bumped the chart version
Changed the logic on exposePrivate boolean value
It looks like this does have a merge conflict to resolve |
Fixed |
Summary
Changes on this PR:
Test Plan
Checklist
plural from-grafana
to convert a grafana dashboard found via google to our CRDpluralsh/module-library
to accelerate this