Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lua support #485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add lua support #485

wants to merge 1 commit into from

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Jan 10, 2023

Summary

Migrate grafana go template to Lua script

Test Plan

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is definitely better, but a part of me wonders if javascript is a bit better from a dev ux perspective. Let's see how this goes and potentially work on embedding js

@@ -0,0 +1,119 @@
output = {
global={
application={
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should definitely have helper functions for these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants