Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cloud shell image CD #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add cloud shell image CD #427

wants to merge 1 commit into from

Conversation

michaeljguarino
Copy link
Member

Summary

Use the upgrade command to auto-deploy new cloud shell image configuration on new version publish

Test Plan

tested the envsubst command locally

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

Use the upgrade command to auto-deploy new cloud shell image configuration on new version publish
@michaeljguarino michaeljguarino added the enhancement New feature or request label Aug 10, 2023
@davidspek
Copy link
Contributor

This seems like it could have serious security implications so I think we should look at it more closely.

@michaeljguarino
Copy link
Member Author

It only is triggered on new releases being published at the moment, and just automates the config update to use the new image tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants